Split docker cli into separate package, deb packaging #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This splits out the CLI into a discrete package and removes the engine from the engine package. Instead the engine is initialized via a post-inst script using the new CLI UX.
dhiltgen
force-pushed
the
revamp_packages
branch
from
254abb2 to
662e248
Compare
dhiltgen
commented
Aug 2, 2018
| # TODO Needs upgrade vs. install logic handling here | ||
| if ctr --namespace docker container info dockerd 2&>1 > /dev/null ; then | ||
| docker engine init | ||
| fi |
There was a problem hiding this comment.
This script is far too naive for the final product, but should be enough to get us bootstrapped.
seemethere
changed the title
|
Updated the PR title to reflect this phase of the package restructuring Bits that are included in the new `docker-ce-cli` packageBits that are included in the new `docker-ce` package |
seemethere
reviewed
Aug 2, 2018
| Priority: optional | ||
| Maintainer: Docker <[email protected]> | ||
| Standards-Version: 3.9.6 | ||
| Homepage: https://dockerproject.org |
There was a problem hiding this comment.
Should change this to https://docker.com
| @@ -10,41 +10,21 @@ override_dh_gencontrol: | |||
| dh_gencontrol | |||
|
|
|||
| override_dh_auto_build: | |||
| cd engine && ./hack/make.sh dynbinary | |||
| cd /go/src/github.com/docker/cli && LDFLAGS='' make VERSION=$(VERSION) GITCOMMIT=$(DOCKER_GITCOMMIT) dynbinary manpages | |||
|
|
|||
| override_dh_auto_test: | |||
There was a problem hiding this comment.
We could probably just remove this target altogether.
|
|
||
| override_dh_install: | ||
| dh_install | ||
| # TODO Can we do this from within our container? |
There was a problem hiding this comment.
possibly, but I think it'd have to be done in the postinst instead.
|
Can confirm that the |
dhiltgen
pushed a commit
to dhiltgen/docker-ce-packaging
that referenced
this pull request
Aug 2, 2018
|
Comments covered in #130 |
|
It seems this PR also removes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits out the CLI into a discrete package and removes
the engine from the engine package. Instead the engine
is initialized via a post-inst script using the new CLI UX.
Currently relies on docker/cli#1260