Add more regions to registry S3 storage driver #2140
Conversation
|
LGTM Looks like there are at least 2 others not in the list, |
|
@dmcgowan I can add them as well here, thx for noticing. |
Namely adding ca-central-1, ap-south-1 and eu-west-1. Signed-off-by: Michal Fojtik <[email protected]>
mfojtik
changed the title
|
LGTM, thanks @mfojtik |
|
LGTM |
|
(note that I haven' tested this yet and I'm worried that I can't grep these endpoint names in aws-sdk-go) |
|
Might need to upgrade the dependency to 1.6.3 then aws/aws-sdk-go@ad048b5 Looks like ap-south-1 and ca-central-1 were added in 1.6.2, eu-west-2 in 1.6.3 aws/aws-sdk-go@1355b45 |
|
Looks like upgrading the dependency will pull in a lot more changes, I am going to move this back to 2.7 release. Maybe could consider for 2.6.1 if it is important for you guys and you have time to test it. |
Current coverage is 51.12% (diff: 100%)@@ master #2140 diff @@
==========================================
Files 125 125
Lines 11432 11435 +3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 6988 5846 -1142
- Misses 3556 4843 +1287
+ Partials 888 746 -142
|
Signed-off-by: Michal Fojtik <[email protected]>
| @@ -1,6 +1,6 @@ | |||
| github.com/Azure/azure-sdk-for-go c6f0533defaaaa26ea4dff3c9774e36033088112 | |||
| github.com/Sirupsen/logrus d26492970760ca5d33129d2d799e34be5c4782eb | |||
| github.com/aws/aws-sdk-go 90dec2183a5f5458ee79cbaf4b8e9ab910bc81a6 | |||
There was a problem hiding this comment.
Looks like the new hash is for 1.6.9, that is fine but was this intended?
There was a problem hiding this comment.
@dmcgowan sorry, 1.6.9 is what I bumped it to :-) (ETOOMUCHPR's ;-)
|
LGTM |
|
LGTM. |
Updated to latest version of go aws sdk. Use vendored sub pakages within aws sdk. Adds missing vendor packages for letsencrypt Fixes #1832 Signed-off-by: Derek McGowan <[email protected]> (github: dmcgowan)
Signed-off-by: Michal Fojtik [email protected]