Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support docker aws regions #12454

Closed
pweil- opened this issue Jan 11, 2017 · 5 comments
Closed

Support docker aws regions #12454

pweil- opened this issue Jan 11, 2017 · 5 comments
Assignees
Labels
component/imageregistry kind/bug Categorizes issue or PR as related to a bug. priority/P1

Comments

@pweil-
Copy link
Contributor

pweil- commented Jan 11, 2017

The region list in the s3 driver is out of date. We are missing us-east-2. The upstream also does not support ca-central-1 - it needs to be added and rebased into our dependency.

https://github.com/docker/distribution/blob/master/registry/storage/driver/s3-aws/s3.go#L104
https://github.com/openshift/origin/blob/master/vendor/github.com/docker/distribution/registry/storage/driver/s3-aws/s3.go#L73

@pweil- pweil- added component/imageregistry kind/bug Categorizes issue or PR as related to a bug. priority/P1 labels Jan 11, 2017
@pweil-
Copy link
Contributor Author

pweil- commented Jan 11, 2017

from @derekwaynecarr

I had to add the following to Kube related items for each release:

3.3 to add missing support for the following: ap-south-1, ca-central-1, us-east-2

3.4 to add missing support for the following: ca-central-1, us-east-2

We should make sure that has parity.

@pweil-
Copy link
Contributor Author

pweil- commented Jan 11, 2017

@DanyC97
Copy link
Contributor

DanyC97 commented Jan 22, 2017

i guess this issue ca be closed?

@pweil-
Copy link
Contributor Author

pweil- commented Feb 3, 2017

#12451

@pweil- pweil- closed this as completed Feb 3, 2017
@tj13
Copy link

tj13 commented Feb 1, 2019

@pweil- +1 for cn-northwest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/imageregistry kind/bug Categorizes issue or PR as related to a bug. priority/P1
Projects
None yet
Development

No branches or pull requests

4 participants