keep the platform defined, in priority, via DOCKER_DEFAULT_PLATFORM o… #9866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glours
force-pushed
the
issue-service-platform-on-up
branch
from
288ee30
to
0ae05e5
Compare
…r the service.plaform one if no build platforms provided Signed-off-by: Guillaume Lours <[email protected]>
glours
force-pushed
the
issue-service-platform-on-up
branch
from
0ae05e5
to
ce3700d
Compare
milas
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r the service.plaform one if no build platforms provided
What I did
During a
compose upwhen theDOCKER_DEFAULT_PLATFORMisn't set, the platform list is reset and theservice.platformdefined in the compose file isn't applied during the build step.Now the
DOCKER_DEFAULT_PLATFORMis applied if defined otherwise theservice.platformis used (if existing of course)Be aware that both are defined and not targeting the same platform you will get the following message (current behaviour):
Related issue
fixes #9864
(not mandatory) A picture of a cute animal, if possible in relation with what you did
