ci: upgrade to Go 1.19.1

[milas]

What I did
Go released 1.18.6 + 1.19.1 today which fix a couple CVEs. (golang.org/x/net also has a related fix.)

This jumps from 1.18.5 -> 1.19.1 since it was on the to-do list regardless :)

Related issue
https://groups.google.com/g/golang-announce/c/x49AQzIVX-s

(not mandatory) A picture of a cute animal, if possible in relation with what you did

[thaJeztah]

Note that the release pipeline is still on 1.18; does the CI matrix also test against that version?

[milas]

The release pipeline in docker/docker-ce-packaging, right? (IIRC we settled on it calls make build from the Makefile in this repo, which does a "local" go build inside of its container but not using buildx bake for the actual Compose build)

How do we generally handle that for other projects packaged by it? Something like this?

• Upgrade project CI to default to Go n+1
• Continue running project CI against Go n & n+1
• Once all projects on Go n+1, change packaging to use Go n+1
• Drop Go n from project CI

cc @glours if you have opinions

[thaJeztah]

You'll have to update golangci-lint to v1.49 probably; note that there's some linters being deprecated (and/or replaced); docker/cli#3768

> [lint 1/1] RUN --mount=type=bind,target=.     --mount=type=cache,target=/root/.cache     --mount=from=golangci-lint,source=/usr/bin/golangci-lint,target=/usr/bin/golangci-lint     golangci-lint run --build-tags "e2e,kube" ./...:
#21 9.836 panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt
#21 9.836 
#21 9.836 goroutine 1 [running]:
#21 9.836 github.com/go-critic/go-critic/checkers.init.22()
#21 9.836 	github.com/go-critic/[email protected]/checkers/embedded_rules.go:47 +0x4b4

[ulyssessouza]

Reading minds! I was about to make this change!