Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a local builder Makefile to easy local dev with compose-go replace #9765

Closed
wants to merge 1 commit into from
Closed

Add a local builder Makefile to easy local dev with compose-go replace #9765

wants to merge 1 commit into from

Conversation

ulyssessouza
Copy link
Collaborator

@ulyssessouza ulyssessouza commented Aug 19, 2022 •
edited
Loading

What I did
Facilitate local development by allowing build with a replace clause in local file system for compose-spec/compose-go in go.mod

make -f local.Makefile

@ulyssessouza ulyssessouza requested a review from a team August 19, 2022 04:19
laurazard
laurazard approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) this should make things a little easier 😅

@thaJeztah thaJeztah mentioned this pull request Aug 19, 2022
Merged
@nicksieger
Copy link
Member

#9776 should obsolete this

@crazy-max crazy-max mentioned this pull request Aug 23, 2022
Merged
@milas milas closed this in #9776 Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurazard laurazard laurazard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ulyssessouza @nicksieger @laurazard