Apply newly loaded envvars to "DockerCli" and "APIClient"

[ulyssessouza]

What I did
Re-evaluate DockerCli and APIClient after reading the environment file.
I can contain DOCKER_HOST and/or DOCKER_CONTEXT so the DockerCli passed by docker/cli has to be re-evaluated.

Related issue
Resolves #9210

[milas]

LGTM

[markdascher]

Hate to be that guy 😄 But this might've broken something, at least on MacOS. I recently updated to docker-compose v2.10 and started getting this error for any docker-compose or docker compose command:

Error response from daemon: Client sent an HTTP request to an HTTPS server.

Using these env vars:

DOCKER_BUILDKIT="1"
DOCKER_TLS_VERIFY="1"
DOCKER_HOST="tcp://192.168…:2376"
DOCKER_CERT_PATH="…/certs"

Tried moving these env vars into an .env file but it didn't help. (Might've been doing it wrong though, since I've never used .env files with docker before.)

git bisect pointed to this commit, and reverting it solved the issue.

[markdascher]

Found out a little more detail here. TLSOptions are only set in one spot, inside of InstallFlags. That method isn't called by the flags.NewClientOptions() added in this PR, which results in dockerCli.dockerEndpoint.EndpointMeta.TLSData becoming nil.

InstallFlags seems like a strange place for that particular code to be tucked away. Also, that file calls os.Getenv in global initializers, which will always be incompatible with the runtime override mechanism added in this PR.

AFAICT there's no workaround, so I just have to use an older version. 2.7.0 is the newest one without a big warning on it, so that's probably the one I'll pick. But I don't know if the issue is really with this PR or if the code in docker/cli should be reworked?

[nicksieger]

@markdascher thanks for the sleuthing, that's helpful. I'd like to see your issue addressed in some way, whether a kludge or rolling back this PR or some other intervention. I filed #9789 to track this.

[trcoelho]

Hello, when this change (docker desktop version) will be available?

Thank you.

[milas]

Copying #9210 (comment) here:

Re-opening because we had to revert #9745 in #9792 because it caused issues with TLS-enabled Docker hosts.

As a result, this is not currently available in the latest release of Docker Compose.

[dmorrison]

I've been struggling for a long time with the "Client sent an HTTP request to an HTTPS server." error in a local dev setup, and @markdascher's suggestion to use an older version fixed my issue! Thank you!!!!!!

[markdascher]

Glad to hear my comment was helpful! But the latest version (or anything after v2.10.2) already reverted this particular change. I'm currently running version 2.18.1 and there's no "Client sent an HTTP request to an HTTPS server" error. So that might be worth a shot, too.

[dmorrison]

Yes, it's strange for me. I was actually on Compose 2.18.1 (included with Docker Desktop 4.20.1) and getting that error. I was on a slightly older version before that (and still getting the error), so I tried upgrading to the latest version, but still got the error. Downgrading to Docker Desktop 4.11.0 (with Compose 2.7.0) fixed it. ¯_(ツ)_/¯

For context, it's for a local web development setup at my company. I tried troubleshooting many parts of it, but downgrading is the only thing that has worked so far. My specific issue was that the local dev app would work when plugged in to a USB to ethernet adapter, but not on wifi.