Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update usage strings for consistency #9706

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

thaJeztah
Copy link
Member

This updates the format of various usage strings to be more consistent
with other parts of the CLI.

  • Use [OPTIONS] to indicate where command-specific options should be added
  • Use [SERVICE...] to indicate zero-or-more services
  • Remove some usage strings for specific options (e.g. -e NAME=VAL), as that
    option is part of the already mentioned [OPTIONS] and we don't provide usage
    for each possible option that can be passed.
  • Remove [--], which (I think) was needed for the Python implementation, but is
    a general feature to stop processing flag-options.

What I did

Related issue

(not mandatory) A picture of a cute animal, if possible in relation with what you did

This updates the format of various usage strings to be more consistent
with other parts of the CLI.

- Use `[OPTIONS]` to indicate where command-specific options should be added
- Use `[SERVICE...]` to indicate zero-or-more services
- Remove some usage strings for specific options (e.g. `-e NAME=VAL`), as that
  option is part of the already mentioned `[OPTIONS]` and we don't provide usage
  for each possible option that can be passed.
- Remove `[--]`, which (I think) was needed for the Python implementation, but is
  a general feature to stop processing flag-options.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Copy link
Collaborator

@ulyssessouza ulyssessouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @thaJeztah

@glours glours merged commit 9e48afb into docker:v2 Aug 2, 2022
@thaJeztah thaJeztah deleted the improve_usage_consistency branch August 2, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants