Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use env variable for golang version and updates gh actions from v2 to v3 #9675

Merged
merged 2 commits into from
Jul 26, 2022
Merged

use env variable for golang version and updates gh actions from v2 to v3 #9675

merged 2 commits into from
Jul 26, 2022

Conversation

glours
Copy link
Contributor

@glours glours commented Jul 25, 2022

What I did
Update the GitHub actions workflows:

  • use an env variable to define the version of Golang used
  • update GitHub base actions to v3

(not mandatory) A picture of a cute animal, if possible in relation with what you did
image

@glours glours self-assigned this Jul 25, 2022
@glours glours marked this pull request as ready for review July 25, 2022 21:32
@glours glours requested a review from a team July 25, 2022 21:32
nicksieger
nicksieger approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@nicksieger nicksieger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice cleanup with the newer actions!

.github/workflows/ci.yml Outdated Show resolved Hide resolved
StefanScherer
StefanScherer approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@StefanScherer StefanScherer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours merged commit ce1829a into docker:v2 Jul 26, 2022
@glours glours deleted the update-gh-workflow branch January 11, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicksieger nicksieger nicksieger approved these changes

@StefanScherer StefanScherer StefanScherer approved these changes

Assignees

@glours glours

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glours @nicksieger @StefanScherer