Add gocritic to linters #9643
Merged
Add gocritic to linters #9643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulyssessouza
requested review from
ndeloof,
nicksieger,
milas,
glours and
laurazard
ulyssessouza
force-pushed
the
add-gocritic-linter
branch
from
7206786
to
6ae2314
Compare
ulyssessouza
force-pushed
the
add-gocritic-linter
branch
2 times, most recently
from
f32f6d5
to
b172b65
Compare
thaJeztah
reviewed
Jul 13, 2022
Signed-off-by: Ulysses Souza <[email protected]>
Signed-off-by: Ulysses Souza <[email protected]>
Signed-off-by: Ulysses Souza <[email protected]>
Signed-off-by: Ulysses Souza <[email protected]>
Reference -> https://golangci-lint.run/usage/false-positives/#nolint-directive Signed-off-by: Ulysses Souza <[email protected]>
ulyssessouza
force-pushed
the
add-gocritic-linter
branch
from
7390f1c
to
fc723ac
Compare
nicksieger
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add
gocriticto the linters