Replace deprecated ioutil pkg with os & io #9595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. So replacing all usage of ioutil pkg with io & os. Signed-off-by: Abhinav Nair <[email protected]>
abhinavnair
force-pushed
the
replace-ioutil
branch
from
506acfe
to
11f2f2d
Compare
|
Thanks! Perhaps would be good to also configure golangci-lint to prevent this package from accidentally being used; similar to docker/cli@8c3ae38 |
This is to prevent anyone from accidentally importing the pkg Signed-off-by: Abhinav Nair <[email protected]>
abhinavnair
force-pushed
the
replace-ioutil
branch
from
a79488c
to
a783cc4
Compare
Thanks for the suggestion. I have added a commit for golangci-lint 👍🏻 |
thaJeztah
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
As of Go 1.16, the same functionality of
ioutilpkg is now provided by packageioorpackage
os, and those implementations should be preferred in new code.So replacing all usage of
ioutilpkg withio&os.Related issue
None
(not mandatory) A picture of a cute animal, if possible in relation with what you did