TC: Use switch case to simplify flag conversion and avoid multiple if statements #9507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheodosiouTh
force-pushed
the
tc/simplify-flag-conversion
branch
2 times, most recently
from
21f5165
to
c56c579
Compare
debdutdeb
reviewed
Jun 30, 2022
There was a problem hiding this comment.
Honestly i don't see the need to use a static one-use map for a simple action like this. There is no benefits to this, no performance gain or anything. Would've made some sense in terms of maintainability if there were a lot of such supp args, but for just four, a couple if statements don't hurt, rather I'd say is better. Probably a better option would be using switch instead (even if the list grows to say 100, a switch statement is far better than a clever use of map. simplicity 😉)
…ents Signed-off-by: ThedosiouTh <[email protected]>
Signed-off-by: ThedosiouTh <[email protected]>
Signed-off-by: ThedosiouTh <[email protected]>
Signed-off-by: ThedosiouTh <[email protected]>
TheodosiouTh
force-pushed
the
tc/simplify-flag-conversion
branch
from
71da899
to
115ac6d
Compare
|
@debdutdeb I understand your way of thinking. Thanks for the review. 😃 |
TheodosiouTh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I used a map to remove multiple if statements from the code and make it easier to add new argument conversions.
Also, I added missing tests for
-vand--verbose.Related issue
There are no related issues.