-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce --pull #9474
introduce --pull #9474
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that docs isn't up to date regarding your changes
Otherwise, LGTM
Docs and code LGTM! Although I had a question: when doing |
@laurazard @ndeloof if you're agree we could merge this PR and open follow-up ones to address Laura's questions/remarks, WDYT? |
@glours I'm okay with that! |
@ndeloof @laurazard I just spend few minutes to add the missing part to make it works with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Works fine now, good catch @glours :)
Signed-off-by: Nicolas De Loof <[email protected]>
add pull flag to create and up documentation Signed-off-by: Guillaume Lours <[email protected]>
I just squashed the last 2 commits commits in one and resolved conflict with the |
What I did
Introduce
--pull
flag so user can force pull of up-to-date service images (same asdocker run --pull
Related issue
close #9451
(not mandatory) A picture of a cute animal, if possible in relation with what you did