Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce --pull #9474

Merged
merged 2 commits into from
Jul 27, 2022
Merged

introduce --pull #9474

merged 2 commits into from
Jul 27, 2022

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented May 17, 2022

What I did
Introduce --pull flag so user can force pull of up-to-date service images (same as docker run --pull

Related issue
close #9451

(not mandatory) A picture of a cute animal, if possible in relation with what you did
image

Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that docs isn't up to date regarding your changes
Otherwise, LGTM

@glours glours requested a review from laurazard May 23, 2022 08:45
@laurazard
Copy link
Member

Docs and code LGTM! Although I had a question: when doing docker compose up --pull always, it behaved as expected: images get pulled every time, containers get recreated. However, when doing docker compose create --pull always, this doesn't happen. Neither does it happen when I do docker compose create --pull always --build --force-recreate, or any combination of flags. What's the expected behaviour for using the --pull always flag when doing docker compose create? I guess it's not super important since create is deprecated, but I figured I would ask.

@glours
Copy link
Contributor

glours commented Jul 4, 2022

@laurazard @ndeloof if you're agree we could merge this PR and open follow-up ones to address Laura's questions/remarks, WDYT?

@laurazard
Copy link
Member

@glours I'm okay with that!

@glours
Copy link
Contributor

glours commented Jul 26, 2022

@ndeloof @laurazard I just spend few minutes to add the missing part to make it works with create command, can you do a quick review?

@glours glours requested a review from laurazard July 26, 2022 15:59
Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Works fine now, good catch @glours :)

ndeloof and others added 2 commits July 27, 2022 11:24
Signed-off-by: Nicolas De Loof <[email protected]>
add pull flag to create and up documentation

Signed-off-by: Guillaume Lours <[email protected]>
@glours
Copy link
Contributor

glours commented Jul 27, 2022

I just squashed the last 2 commits commits in one and resolved conflict with the v2 branche

@laurazard laurazard merged commit 085d8e9 into docker:v2 Jul 27, 2022
@ndeloof ndeloof deleted the pull_no_pull branch July 27, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support --no-pull option on compose up
3 participants