-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump compose-go 1.1.0 #9219
Bump compose-go 1.1.0 #9219
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Ulysses Souza <[email protected]>
3e9cd82
to
16914e3
Compare
Wait, wait? "Proposal: make project-name persistent, #745" got implemented with this?! 🎉 |
@glensc yep 👍 |
however, found the pr with changes: and then description of the changes: |
We can't say it was secretive 😅 , the Compose Specification is public and the #745 where mentioned in this Compose Spec update PR |
I tried to say it feels secretive, as #745 was closed automatically, and it refers to #9219, which has some technical description, not seemingly related to the problem at hand. could the original issue be closed by accident I was wondering? so I had to find what that compose-go is, and their 1.1.0 release notes also said nothing, and it also has no changelog, so had to visit their commits to find a related pull request ... What would feel better is a post there saying something along "Hooray, we have released docker-compose 1.32 (includes docker-go 1.1.0) with the support of "name", it will be available on 1st of April and if you use docker desktop then it will be bundled with next update" :) |
Ok thanks for your feedback, I updated the compose-go release notes |
What I did
Bump compose-go 1.1.0
Related issue
Resolves #745