Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(re)start should not impact one-off containers #9049

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Dec 17, 2021

What I did
start/restart only considered service containers

Related issue
#9044

(not mandatory) A picture of a cute animal, if possible in relation with what you did

…offs

Also add e2e tests.

Signed-off-by: Laura Brehm <[email protected]>
@laurazard
Copy link
Member

laurazard commented Jun 28, 2022

Ahh, I didn't mean to overwrite the your commit @ndeloof, it just needed some changes and then I added e2e tests 😓 . I'm sorry!

@laurazard laurazard requested a review from a team June 28, 2022 23:05
@laurazard laurazard self-assigned this Jun 28, 2022
Copy link
Member

@nicksieger nicksieger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours merged commit cd94069 into docker:v2 Jun 29, 2022
@ndeloof ndeloof deleted the 9044 branch December 20, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants