docker-compose up --scale, scale in config file #4742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmat docker-compose scale modified to reuse code between up and scale Signed-off-by: Joffrey F <[email protected]>
Signed-off-by: Joffrey F <[email protected]>
shin-
force-pushed
the
2496-new_scale
branch
3 times, most recently
from
d3cef10
to
b325579
Compare
Signed-off-by: Joffrey F <[email protected]>
shin-
changed the title
dnephin
reviewed
Apr 26, 2017
| raise UserError( | ||
| 'The scale command is incompatible with the v2.2 format. ' | ||
| 'Use the up command with the --scale flag instead.' | ||
| ) |
There was a problem hiding this comment.
Could we relax this restriction and only error if the config file contains scale: fields in the config?
I think that will remove the need to store config_version on the project as well.
| @@ -875,7 +874,7 @@ def up(self, options): | |||
| If you want to force Compose to stop and recreate all containers, use the | |||
| `--force-recreate` flag. | |||
|
|
|||
| Usage: up [options] [SERVICE...] | |||
| Usage: up [options] [--scale SERVICE=NUM...] [SERVICE...] | |||
There was a problem hiding this comment.
I think this would just be part of options like the other options?
There was a problem hiding this comment.
I think we have to declare it separately because it's repeatable. Same goes for build for example:
Usage: build [options] [--build-arg key=val...] [SERVICE...]
or run:
Usage: run [options] [-v VOLUME...] [-p PORT...] [-e KEY=VAL...] SERVICE [COMMAND] [ARGS...]
Signed-off-by: Joffrey F <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #2496
This is a slight variant of Daniel's proposal in #2496. It adds a
--scaleflag instead of overloading the functionality of the services list, which works around the issue described in #1661 (comment)The
--scaleoption will be available for all versions of the Compose file, but thescaleconfig option will only be added in file format 2.2. As a result,docker-compose scalewith a 2.2 config file will be prohibited.deploy.replicasmight be considered as synonym toscalein the v3 format, but would be an independent addition (i.e. not in this PR).