-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secrets using bind mounts #4368
Conversation
@dnephin Do you need help looking into those?
|
Oops, I didn't notice. I'll look into them |
1b04217
to
1091d9d
Compare
I fixed the TypeErrors, but the other test is passing locally. From the failure it sounds like the file doesn't exist on the "host", so the bind mount is creating the path as a directory. |
ae329ee
to
5b40fe8
Compare
ok, tests are fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small change, otherwise LGTM
tests/integration/project_test.py
Outdated
with open(filename, 'r') as fh: | ||
content = fh.read() | ||
|
||
print(content) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove debug statement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, removed
Signed-off-by: Daniel Nephin <[email protected]>
Signed-off-by: Daniel Nephin <[email protected]>
Signed-off-by: Daniel Nephin <[email protected]>
Signed-off-by: Daniel Nephin <[email protected]>
Signed-off-by: Daniel Nephin <[email protected]>
Signed-off-by: Daniel Nephin <[email protected]>
Signed-off-by: Daniel Nephin <[email protected]>
5b40fe8
to
59d1847
Compare
Fake secrets in
docker-compose
using bind mountsSee moby/moby#30144 for the feature in
docker stack deploy