Implement cache from #4310
Closed
Implement cache from #4310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Schaaf <[email protected]>
thomaschaaf
commented
Jan 9, 2017
| @@ -594,6 +594,20 @@ def test_build_with_build_args(self): | |||
| service.build() | |||
| assert service.image() | |||
|
|
|||
| @v2_only() | |||
thomaschaaf
commented
Jan 9, 2017
| @@ -56,9 +56,10 @@ | |||
| { | |||
| "type": "object", | |||
| "properties": { | |||
| "args": {"$ref": "#/definitions/list_or_dict"}, | |||
| "cachefrom": {"$ref": "#/definitions/list_of_strings"}, | |||
There was a problem hiding this comment.
Am I allowed to add it to the 2.0 schema?
|
Since the docker-py issue was merged in, this can be retested and reviewed, no? |
thomaschaaf
force-pushed
the
cachefrom
branch
from
3ce31aa to
ed3a331
Compare
Signed-off-by: Thomas Schaaf <[email protected]>
thomaschaaf
force-pushed
the
cachefrom
branch
from
1e3a41b to
811c1f1
Compare
|
Closing via #4514 - Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4309
Depends on: docker/docker-py#1383
Signed-off-by: Thomas Schaaf [email protected]