Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a contributing page. Refs #123 #133

Merged
merged 1 commit into from
Mar 4, 2014
Merged

Add a contributing page. Refs #123 #133

merged 1 commit into from
Mar 4, 2014

Conversation

kvz
Copy link

@kvz kvz commented Mar 4, 2014

Here's a first swing at a contributing page in the documentation. I'm not a Python developer and hearing about python setup.py develop pretty much saved me. Other potential contributors might not know the PR flow. I figured it would be cool to lay out all the steps involved to making a Fig contribution as to lower the bar of entry.

I might still be overlooking steps still, but/so let's add them.

@bfirsh
Copy link

bfirsh commented Mar 4, 2014

Looks great – thanks. Maybe this would be better as part of the README instead of the user docs? If you're interested in contributing, you'll be going to the repo anyway.

@kvz
Copy link
Author

kvz commented Mar 4, 2014

Alright, added them to README instead

@bfirsh
Copy link

bfirsh commented Mar 4, 2014

Lovely stuff – thanks. Any chance you could rebase so we just get the last commit?

@bfirsh
Copy link

bfirsh commented Mar 4, 2014

(I can sort this if you'd like)

@kvz
Copy link
Author

kvz commented Mar 4, 2014

Here's the one commit --^

bfirsh added a commit that referenced this pull request Mar 4, 2014
@bfirsh bfirsh merged commit 65f3411 into docker:master Mar 4, 2014
@bfirsh
Copy link

bfirsh commented Mar 4, 2014

Amazing, thanks!

yuval-k pushed a commit to yuval-k/compose that referenced this pull request Apr 10, 2015
Add a contributing page. Refs docker#123
Signed-off-by: Yuval Kohavi <[email protected]>
xulike666 pushed a commit to xulike666/compose that referenced this pull request Jan 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants