-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advanced config file #1233
Advanced config file #1233
Conversation
Bump |
Ping @aanand, @bfirsh, @dnephin, @mnowster: any word on whether this is acceptable? Or reasons as to why not (besides the needed DCO sign-off)? Having a project name in the yml (which is only part of this PR) would go a long way to help swarm integration since name conflicts occur often in multi-team environments. |
I'd like to see a "services" entrypoint as well. Once you moved the services from global, you're free too add more keys at the root of the file, It'd be cool to let the format open for extension. For example, I'd like to add a "commands" key at the root of the file to enable a third party tool to read its config inside the compose yml file. |
Anyway this can be modified to support a / separator instead of _ optionally with a flag something like...
would build foo/db and foo/web. If it could be made to do that this would be a super helpful pr that would fix many issues that I have to write custom scripts for right now. |
Thanks for the contribution! Sorry it's taken a while to respond. Our focus so far on the config has been to improve the validation and error messages. In the upcoming 1.5.0 release we've got a new I think we'd like to add a version to the schema, which may happen as part of #2113. If we're going to break backwards compatibility (or even just introduce a new format), we'd like to make a bunch of changes all at once (not just adding a version in isolation). Sorry we weren't ready to make this breaking change when this PR was first submitted. Our configuration code has changed significantly since then, so I don't think we'll be able to merge this PR. |
This PR improve the config schema by moving the services under a new top level node
services
.Why ?
What the difference with #463 ?
This PR does not mix service declaration and project configuration:
I implement an usage of this new schema with an optional property
project
which replace the directory_nameThis should fix tickets #45, #745
Then we could extends this schema to fix #210, #318
note: The script does not break backward compatibility 😃 even if someone already use a service named
project
or.project
orversion
or wathever