Fix race condition in log printer #11286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code used an atomic bool to guard channel writes. However, this failed to synchronize with the call to close(), causing a panic. Fix the race condition by using a mutex to guard the update to the bool `stopped` and subsequent channel writes. This ensures atomic execution of both updates to `stopped` and channel writes, preventing races between writes and close(). Signed-off-by: horus <[email protected]>
horus
force-pushed
the
fix/logprinter-channel-race
branch
from
95b9cab to
20fe2f3
Compare
ndeloof
approved these changes
Dec 20, 2023
|
I (for once!) got this exact same issue easily reproduced with a test compose.yaml file and confirmer this fix it, thanks |
ndeloof
changed the title
|
Also as a daily user, I'm glad that this issue could be resolved in just a few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
The code used an atomic bool to guard channel writes. However, this failed to synchronize with the call to
close(), causing a panic.Fix the race condition by using a mutex to guard the update to the bool
stoppedand subsequent channel writes. This ensures atomic execution of both updates tostoppedand channel writes, preventing races between writes andclose().Related issue
Closes #11280
(not mandatory) A picture of a cute animal, if possible in relation to what you did
