Make it context aware and add test skipping options through environment variables
#11192
Conversation
ulyssessouza
force-pushed
the
exclude-tests-context
branch
from
1048a78
to
89e5bc6
Compare
Signed-off-by: Ulysses Souza <[email protected]>
ulyssessouza
force-pushed
the
exclude-tests-context
branch
from
89e5bc6
to
8ea7c9e
Compare
| @@ -30,6 +30,7 @@ import ( | |||
| "testing" | |||
| "time" | |||
|
|
|||
| cp "github.com/otiai10/copy" | |||
There was a problem hiding this comment.
I wonder you could use https://github.com/moby/moby/blob/master/daemon/graphdriver/copy/copy.go#L124 as we already depend on moby and this would about an additional dependency
There was a problem hiding this comment.
I tried but kept on getting a very strange error:
# github.com/docker/docker/pkg/chrootarchive
../../../../pkg/mod/github.com/docker/[email protected]+incompatible/pkg/chrootarchive/archive_unix.go:31:8: undefined: goInChroot
../../../../pkg/mod/github.com/docker/[email protected]+incompatible/pkg/chrootarchive/archive_unix.go:53:8: undefined: goInChroot
../../../../pkg/mod/github.com/docker/[email protected]+incompatible/pkg/chrootarchive/diff_unix.go:45:8: undefined: goInChroot
FAIL github.com/docker/compose/v2/pkg/e2e [build failed]
There was a problem hiding this comment.
I'd avoid the graphdriver packages as they are really intended for the daemon (and don't have macos implementations)
Perhaps (but typing from my phone) the copy package in fsutils could work? Is this just to copy a directory? https://github.com/tonistiigi/fsutil/tree/master/copy
There was a problem hiding this comment.
right, I just wondered, but that's ok
(I just miss the ability to define test-only dependencies in go.mod. I miss you pom.xml :)
What I did
EXCLUDE_E2E_TESTS).Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did
