add support for start_interval #10939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can someone fix this? |
|
Hi there! Any news? |
|
This PR is a draft, waiting for docker engine 1.25 to be released with API to support this new parameter |
ndeloof
force-pushed
the
starrt_interval
branch
2 times, most recently
from
4c68049 to
89348d2
Compare
ndeloof
commented
Nov 20, 2023
pkg/compose/compose.go
Outdated
Comment on lines
300
to
329
|
|
||
| var runtimeVersion = struct { | ||
| once sync.Once | ||
| val string | ||
| err error | ||
| }{} | ||
| } | ||
|
|
||
| func (s *composeService) RuntimeVersion(ctx context.Context) (string, error) { | ||
| runtimeVersion.once.Do(func() { | ||
| version, err := s.dockerCli.Client().ServerVersion(ctx) | ||
| if err != nil { | ||
| runtimeVersion.err = err | ||
| } | ||
| runtimeVersion.val = version.APIVersion | ||
| }) | ||
| return runtimeVersion.val, runtimeVersion.err | ||
|
|
||
| } |
ndeloof
force-pushed
the
starrt_interval
branch
from
89348d2 to
e5a4575
Compare
ndeloof
force-pushed
the
starrt_interval
branch
from
e5a4575 to
17b9dd6
Compare
ndeloof
requested review from
a team,
glours and
milas
and removed request for
a team
ndeloof
force-pushed
the
starrt_interval
branch
2 times, most recently
from
8bb0321 to
4d1cd29
Compare
Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
force-pushed
the
starrt_interval
branch
from
4d1cd29 to
a1d2820
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #10939 +/- ##
==========================================
- Coverage 56.34% 56.29% -0.05%
==========================================
Files 134 134
Lines 11560 11574 +14
==========================================
+ Hits 6513 6516 +3
- Misses 4407 4416 +9
- Partials 640 642 +2 ☔ View full report in Codecov by Sentry. |
tianon
reviewed
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
add support for start_interval
Related issue
closes #10830
(not mandatory) A picture of a cute animal, if possible in relation to what you did