watch: move sync logic into separate package #10791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milas
requested review from
nicksieger,
ndeloof,
StefanScherer,
ulyssessouza,
glours and
laurazard
and removed request for
a team
milas
force-pushed
the
watch-refactor-sync
branch
from
5a1a0f1 to
cb4427e
Compare
ndeloof
approved these changes
Jul 18, 2023
glours
force-pushed
the
watch-refactor-sync
branch
from
cb4427e to
edbbea3
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10791 +/- ##
==========================================
- Coverage 60.04% 59.97% -0.08%
==========================================
Files 117 118 +1
Lines 10043 10065 +22
==========================================
+ Hits 6030 6036 +6
- Misses 3418 3435 +17
+ Partials 595 594 -1
☔ View full report in Codecov by Sentry. |
Just moving some code around in preparation for an alternative sync implementation that can do bulk transfers by using `tar`. Signed-off-by: Milas Bowman <[email protected]>
glours
force-pushed
the
watch-refactor-sync
branch
from
edbbea3 to
cb17c3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Just moving some code around in preparation for an alternative sync implementation that can do bulk transfers by using
tar.Related issue
https://docker.atlassian.net/browse/ENV-191
(not mandatory) A picture of a cute animal, if possible in relation to what you did
