assume we receive logs by lines and don't ignore those without EOL #10660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
container_log_no_eol
branch
from
5954508 to
a027778
Compare
ndeloof
force-pushed
the
container_log_no_eol
branch
from
a027778 to
f7012e1
Compare
ndeloof
requested review from
a team,
nicksieger,
StefanScherer,
ulyssessouza,
milas and
laurazard
and removed request for
a team
ndeloof
force-pushed
the
container_log_no_eol
branch
from
f7012e1 to
a71a3a6
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10660 +/- ##
==========================================
- Coverage 59.79% 59.77% -0.02%
==========================================
Files 107 107
Lines 9481 9487 +6
==========================================
+ Hits 5669 5671 +2
- Misses 3232 3234 +2
- Partials 580 582 +2
☔ View full report in Codecov by Sentry. |
laurazard
reviewed
Jun 6, 2023
laurazard
reviewed
Jun 6, 2023
ndeloof
force-pushed
the
container_log_no_eol
branch
from
a71a3a6 to
38bb111
Compare
laurazard
approved these changes
Jun 6, 2023
milas
approved these changes
Jun 6, 2023
There was a problem hiding this comment.
LGTM!
Also 😂 I thought this sounded familiar: #8605 (comment)
ndeloof
force-pushed
the
container_log_no_eol
branch
from
38bb111 to
26a6109
Compare
Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
force-pushed
the
container_log_no_eol
branch
from
26a6109 to
1d15914
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
as we attach to containers we receive output as a low-level
Write([]byte)that we split into lines to prepend container prefixif container log doesn't include an EOL character we won't dump it to logs
This PR assumes we don't get container output per character but as full lines (which is the case AFAICT) so that we dump logs as we receive them
Related issue
fixes #10658
(not mandatory) A picture of a cute animal, if possible in relation to what you did