Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cuke tests for port conflicts #10627

Merged
merged 2 commits into from
May 27, 2023

Conversation

nicksieger
Copy link
Member

What I did

Add a cuke feature to test compose errors with port conflicts. I was trying to reproduce an error I was seeing in a different project, but these tests behaved as expected. Want some free tests?

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (06ec064) 59.45% compared to head (2ca8ab9) 59.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2   #10627      +/-   ##
==========================================
+ Coverage   59.45%   59.47%   +0.02%     
==========================================
  Files         107      107              
  Lines        9395     9395              
==========================================
+ Hits         5586     5588       +2     
+ Misses       3236     3234       -2     
  Partials      573      573              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nicksieger nicksieger force-pushed the test-cucumber-port-conflict branch from 897b6d9 to 2ca8ab9 Compare May 26, 2023 20:54
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicksieger nicksieger merged commit b4924de into docker:v2 May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants