Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs to reflect dry run mode is feature complete #10604

Merged
merged 3 commits into from
May 31, 2023
Merged

update docs to reflect dry run mode is feature complete #10604

merged 3 commits into from
May 31, 2023

Conversation

aevesdocker
Copy link
Contributor

What I did

Updated the docs to reflect the incoming change with DD4.20 where Dry Run mode is now feature complete

@aevesdocker
Copy link
Contributor Author

@glours I'm getting the same error as I did with the Compose Spec repo. Is it possible to amend the makefile again?

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (83ad5e9) 59.45% compared to head (65b714c) 59.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2   #10604      +/-   ##
==========================================
+ Coverage   59.45%   59.47%   +0.02%     
==========================================
  Files         107      107              
  Lines        9395     9395              
==========================================
+ Hits         5586     5588       +2     
+ Misses       3236     3234       -2     
  Partials      573      573              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours merged commit 419fcdd into docker:v2 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants