Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compose schema version 3.8 support #6530

Closed
chris-crone opened this issue Feb 20, 2019 · 7 comments · Fixed by #7217
Closed

Compose schema version 3.8 support #6530

chris-crone opened this issue Feb 20, 2019 · 7 comments · Fixed by #7217
Assignees
@aiordache
Labels
kind/feature
Milestone
1.26.0

Comments

@chris-crone
Copy link
Member

Add support for Compose schema version 3.8 to bring in line with Docker CLI.

See: docker/cli#1410
@chris-crone chris-crone added this to the 1.25.0 milestone Feb 20, 2019
@sirlatrom
Copy link

Also see docker/cli#1746 (another new field in 3.8)

@sirlatrom
Copy link

sirlatrom commented Mar 28, 2019 •
edited by thaJeztah
Loading

I'm hoping this one will make it in: docker/cli#1783, so in case it looks like it will, I'll be happy to contribute its counterpart in docker-compose.

@chris-crone
Copy link
Member Author

@sirlatrom that'd be great, thanks!

@sirlatrom
Copy link

@sirlatrom that'd be great, thanks!

As soon as I get an LGTM from @thaJeztah on docker/cli#1783, I'll push a PR for Compose 3.8. AFAICT it's just a bit of admin-like work by copying over the spec JSON file and adding references to it in a few places.

@queicherius queicherius mentioned this issue Jun 29, 2019
Closed
@aldoborrero
Copy link

Any news on this issue? Is somebody working on it?

sirlatrom added a commit to sirlatrom/compose that referenced this issue Jul 29, 2019
@sirlatrom
Copy over compose format 3.8 from docker/cli
816effe 
Fixes docker#6530.

Signed-off-by: Sune Keller <[email protected]>
@sirlatrom sirlatrom mentioned this issue Jul 29, 2019
Closed
sirlatrom added a commit to sirlatrom/compose that referenced this issue Jul 29, 2019
@sirlatrom
Copy over compose format 3.8 from docker/cli
611777e 
Resolves docker#6530.

Signed-off-by: Sune Keller <[email protected]>
@sirlatrom
Copy link

I believe #6823 resolves this issue.

sirlatrom added a commit to sirlatrom/compose that referenced this issue Aug 15, 2019
@sirlatrom
Copy over compose format 3.8 from docker/cli
46b840a 
Resolves docker#6530.

Signed-off-by: Sune Keller <[email protected]>
@johncolby johncolby mentioned this issue Aug 30, 2019
Closed
@ulyssessouza ulyssessouza modified the milestones: 1.25.0, 1.26.0 Nov 14, 2019
@aiordache aiordache self-assigned this Jan 21, 2020
@ndeloof
Copy link
Contributor

ndeloof commented Jan 22, 2020 •
edited
Loading

Don't forget to document changed introduced by 3.8 on https://docs.docker.com/compose/compose-file/compose-versioning/

@aiordache aiordache mentioned this issue Feb 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aiordache aiordache

Labels
kind/feature
Projects
None yet
Milestone
1.26.0
6 participants
@aldoborrero @ndeloof @ulyssessouza @sirlatrom @aiordache @chris-crone