-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] service is required by service but is disabled #10751
Comments
I'm working around this by adding these steps to my failing job: - name: Log Docker Compose version
run: docker compose version
- name: Ensure Docker CLI plugins directory exists
run: mkdir -pv "${HOME}"/.docker/cli-plugins
- name: Download working version of Docker Compose
run: wget -nv -O "${HOME}"/.docker/cli-plugins/docker-compose "${DOCKER_COMPOSE_URL}"
env:
DOCKER_COMPOSE_URL: https://github.com/docker/compose/releases/download/v2.18.1/docker-compose-linux-x86_64
- name: Make Docker Compose binary executable
run: chmod -v +x "${HOME}"/.docker/cli-plugins/docker-compose
- name: Assert that the version of Docker Compose is as expected
run: set -o pipefail && docker compose version | tee /dev/stderr | grep -q 'v2\.18\.1$' It seems to work, and the download is very fast, presumably because it's all within GitHub. |
I can confirm that the version |
I'm not able to reproduce this with the example given. (Tweaked slightly to fix syntax errors and not use a local build, I'm launching an container that just does nothing.) services:
test:
profiles:
- test
image: busybox
init: true
command: ["sleep", "infinity"]
depends_on:
- postgres
postgres:
image: postgres:14-alpine
If I run
With
It also works when I specify Could someone who is hitting this issue give a different minimal repro? |
Also getting hit with this. Command that is failing is version: "3"
services:
...
chessclub:
restart: on-failure
build:
context: ./api
target: dev
depends_on:
db:
condition: service_healthy
cache:
condition: service_started
volumes:
....
env_file:
- .env
healthcheck:
test: curl --fail -s http://localhost:8080/api/status || exit 1
interval: 1s
timeout: 10s
retries: 30
db:
image: postgres
restart: on-failure:10
volumes:
- pgdata:/var/lib/postgresql/data
environment:
POSTGRES_USER: ${POSTGRES_USER}
POSTGRES_PASSWORD: ${POSTGRES_PASSWORD}
POSTGRES_DB: ${POSTGRES_DB}
healthcheck:
test: pg_isready -d ${POSTGRES_DB} -U ${POSTGRES_USER}
interval: 3s
timeout: 5s
retries: 10
... |
It seems like it specifically fails if the service we want to run with no deps has to be built; this repo has a consistently failing minimal project: https://github.com/luord/dc-test The only change is from On that note, a workaround that seems to work for me that doesn't require reinstalling the previous docker version is building the image before
|
This is a bug introduced in docker compose v2.19.0: docker/compose#10751
This is a bug introduced in docker compose v2.19.0: docker/compose#10751
This is a bug introduced in docker compose v2.19.0: docker/compose#10751
This is a bug introduced in docker compose v2.19.0: docker/compose#10751
Was able to update my local workstation to the latest docker compose and confirm what luord said is the same impact I am seeing. If you use an image, the failure does not seem to occur. I however still encounter this error after running docker compose build commands... Example:
Dockerfile:
CLI output:
|
I've also got this problem after updating to However, I'm getting the error message only with compose files that use 2 levels of extending. In my particular case I also use 2 separate YAML files. For example, in this case I would get the error message shown bellow: ## in file 'common.yml'
services:
service_A:
profiles:
- dummy
....
service_B:
profiles:
- dummy
extends: service_A
depends_on: service_A
....
## in file 'concrete.yml'
services:
service_C:
profiles:
- concrete
extends: service_B
depends_on: service_B
.... The error message in this case would be:
However, the following service would be built just fine: ## in file 'another.yml'
services:
service_D:
profiles:
- another
extends: service_A
depends_on: service_A
.... Hopefully it helps by troubleshooting. |
* General nih tables exporting * Lint fixes and tests added * Fixes PR review * Fix: CI can't run the analysis step (docker error) (#1957) This is a bug introduced in docker compose v2.19.0: docker/compose#10751 * General nih tables exporting * Lint fixes and tests added * Fixes PR review * Revert "Merge branch '1905-general-nih-tables' of https://github.com/instedd/cdx into 1905-general-nih-tables" This reverts commit 32366c1. * Revert "Revert "Merge branch '1905-general-nih-tables' of https://github.com/instedd/cdx into 1905-general-nih-tables"" This reverts commit 8994214. * Fixes PR review * Zip as buffer --------- Co-authored-by: Julien Portalier <[email protected]>
I'm having this issue on version
Basically when I'm restarting the |
Yeah. This seems to be a bad bug. I couldn't restart my nextcloud instance so the I was very confused for a few hours. |
I've encountered the same bug today after updating docker:
Service can be restarted by update |
I think the issue is still present on version |
I'm hitting this issue on 2.20.2 as well |
A little more background. It appears sometime between 1.18.2 and now docker compose began following the profiles rule outlined here: https://docs.docker.com/compose/profiles/#auto-enabling-profiles-and-dependency-resolution Previously, a service with no profile would trigger a build on a dependent service even if that one had a profile. Example file that causes an issue.
Removing the |
Uhm @bdashrad I don't think this is the case, in my case the list of profiles is always empty. Furthermore, I noticed this only happens when running |
#8427) * Update DOCKER.md - Correct docker compose versions - bug from 2.19.0 upwards Docker Compose version 2.19.0 and up has a 'fix' that enables dependency checks for services that are not used. The previous behavior was to silently ignore missing dependencies. As such, this confuses users and so I have made small changes to the documentation under the 'Checking Docker versions' portion to clarify these issues, until such a fix is released. See docker compose issue here - docker/compose#10751 * Update readme-docs/DOCKER.md Co-authored-by: Cody Maffucci <[email protected]> --------- Co-authored-by: Cody Maffucci <[email protected]>
I'm hitting this issue in |
I'm encountered the same bug and then upgrade my Docker Desktop. |
Still not fixed for me, see #10892 |
Encountering the same issue, updating to |
Seeing this on 2.23.0 as well |
Still seeing this too, on latest Docker Desktop:
|
Ah I see, the behavior I'm seeing is the same as mentioned above:
Also discussed in this article: https://nickjanetakis.com/blog/optional-depends-on-with-docker-compose-v2-20-2 And confirmed by this comment over here:
Basically we've got a setup like: services:
db:
image: postgres
redis:
image: redis
web:
image: web
depends_on:
db:
condition: service_healthy
redis:
condition: service_healthy
backend1:
image: backend1
depends_on:
web:
condition: service_healthy
profiles:
- full_stack
backend2:
image: backend2
depends_on:
web:
condition: service_healthy
profiles:
- full_stack
celery:
image: celery
depends_on:
db:
condition: service_healthy
redis:
condition: service_healthy
web:
condition: service_healthy
backend1:
condition: service_healthy
backend2:
condition: service_healthy We use a And we want But in docker compose v2.19+ we get the error:
And it seems like celery:
image: celery
depends_on:
db:
condition: service_healthy
redis:
condition: service_healthy
web:
condition: service_healthy
backend1:
condition: service_healthy
required: false
backend2:
condition: service_healthy
required: false But that caused Is there a plan to support profile + depends_on in the future? Or do we need to use compose extend/merge instead? |
@alexburner such a "select by profile" pattern is not supported, profiles are designed to add optional services to a compose model, not to switch components. An approach I have in mind to address this need relies on compose-spec/compose-spec#404 |
@ndeloof You say Now compose team fixed a "bug" that many people used as "feature" because they don't have another alternative, these people just felt left out because not a single solution is available anymore after version Ok, now we stick to Now, #9795 says Suggested proposal like this:
By making |
"switch components" is a perfectly valid usage. The simplest approach for now is to rely on multiple compose files. We don't have a better way yet, maybe some will come. About your proposal, same can be achieved already by declaring service |
Since I'm inclined to make a proposal of Example use caseSay we have following directory layout:
Where root networks:
...
secrets:
...
include:
- minio/compose.yml
- gitlab/compose.yml
- sharelatex/compose.yml And root COMPOSE_PROFILES=* # all Here:
Now, we can select one of the components through:
And manage all services by not providing profile (because
Proposal about
|
sounds to me like a terrible pattern!
this is why You can then use: include:
- ${BACKEND:-sharelatex}/compose.yml .. which will load sharelatex implementation by default, but you can select another one by just setting |
COMPOSE_PROFILES=minio,gitlab,sharelatex It doesn't matter, because we can still use In fact, since these components are already explicitly declared in root networks:
...
secrets:
...
include:
- minio/compose.yml
- gitlab/compose.yml
- sharelatex/compose.yml Explicitly write default profiles in Command line provided
So
This still has the problem that if
But this selects If we include
This:
|
no. If sharelatex includes minio (as it depends on this component) you don't have to. includes is transitive |
I've mentioned this in second example (include I've opened a PR at compose-spec/compose-spec#488 to introduce |
* Downgrade docker compose from 2.19.1 to 2.18.1 Because of docker/compose#10751 * Revert "Downgrade docker compose from 2.19.1 to 2.18.1" Because docker compose 2.20.2 solves the issue. This reverts commit d0e25e5. * Downgrade JDK from 11.0.20 to to 11.0.19 (felipecrs#76) * Align remoting version with jenkins/docker-agent So we don't try to use non-tested versions of the remoting library. Also adds some dependencies from jenkins/docker-agent that were missing in this image. * Bump dind hack to latest version * Clean not needed data like man pages * Switch skopeo installation to skopeo-bin * Upgrade fixuid from 0.5.1 to 0.6.0 * Add retry (felipecrs#80) * Fix some hadolint issues * Bump actions/checkout from 3 to 4 (felipecrs#81) Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump docker/metadata-action from 4 to 5 (felipecrs#85) Bumps [docker/metadata-action](https://github.com/docker/metadata-action) from 4 to 5. - [Release notes](https://github.com/docker/metadata-action/releases) - [Upgrade guide](https://github.com/docker/metadata-action/blob/master/UPGRADE.md) - [Commits](docker/metadata-action@v4...v5) --- updated-dependencies: - dependency-name: docker/metadata-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump docker/build-push-action from 4 to 5 (felipecrs#84) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 4 to 5. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v4...v5) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump docker/login-action from 2 to 3 (felipecrs#83) Bumps [docker/login-action](https://github.com/docker/login-action) from 2 to 3. - [Release notes](https://github.com/docker/login-action/releases) - [Commits](docker/login-action@v2...v3) --- updated-dependencies: - dependency-name: docker/login-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump docker/setup-buildx-action from 2 to 3 (felipecrs#82) Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 2 to 3. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@v2...v3) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Honor default shell in /ssh-command/get.sh * Upgrade s6-overlay from v2 to v3 (felipecrs#78) * Revert "Downgrade JDK from 11.0.20 to to 11.0.19 (felipecrs#76)" (felipecrs#86) This reverts commit 0c9a5a9. * Revert "Upgrade s6-overlay from v2 to v3 (felipecrs#78)" This reverts commit b074844, due to just-containers/s6-overlay#558. * Upgrade s6-overlay from v2 to v3 (felipecrs#78)"" This reverts commit 70ec592. Refs felipecrs#78 Refs just-containers/s6-overlay#558 (comment) * Downgrade and pin Node.js to v18 (felipecrs#90) * Bump peter-evans/dockerhub-description from 3 to 4 (felipecrs#91) Bumps [peter-evans/dockerhub-description](https://github.com/peter-evans/dockerhub-description) from 3 to 4. - [Release notes](https://github.com/peter-evans/dockerhub-description/releases) - [Commits](peter-evans/dockerhub-description@v3...v4) --- updated-dependencies: - dependency-name: peter-evans/dockerhub-description dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update Ubuntu 20.04 to 22.04 * Fix minor README issues (felipecrs#93) * Extract image preparation into a separate script and improve it (felipecrs#94) Among other things, the new script no longer needs add-apt-repository, changes the kubernetes debian repository to the new one. As part of this improvement, we also change the base image from buildpack to ubuntu, while still keeping the build-essential package installed. This allows to trim the image size a little bit. * Stop publishing to Docker Hub (felipecrs#95) I prefer to concentrate on publishing to GitHub Container Registry, so that I don't need to maintain two accounts and also because this way all download counts are in one place. As part of this change, I also removed the Docker image from Docker Hub, so that when users try to download it again, it will fail and therefore notice that the image is no longer available there. Otherwise, they would keep using the old image without noticing that it's no longer updated. * Remove btrfs-progs and add pigz for faster docker pulls (felipecrs#96) * Remove non-generic packages from image but add pkgx (felipecrs#97) * Set docker daemon log-level to warn by default (felipecrs#98) And remove deprecated fix-attrs. * Use same JDK as jenkins/inbound-agent (upgrade to 17) (felipecrs#89) * Add automatic tests (felipecrs#59) * Add support for `arm64` architecture (felipecrs#75) * Add Oh My Bash and nano to make debugging the container easier (felipecrs#99) * Add mention to pkgx and sshd into README * Allow to run with docker on docker mode (felipecrs#100) * Setup dond-shim when running in docker on docker mode (felipecrs#101) * Configure Renovate (felipecrs#102) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Felipe Santos <[email protected]> * Format json files * Enable Renovate automerge and dependency dashboard * Remove nightly docker tags and other dev improvements * Fix build and Renovate regex * Reorganize README * Allow to run as a devcontainer (felipecrs#104) * Configure Renovate to update Docker (felipecrs#106) * Update dependency felipecrs/fixdockergid to v0.7.1 * Update dependency docker/buildx to v0.13.0 * Update dependency moby/moby to v25.0.4 (felipecrs#110) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency docker/compose to v2.24.7 (felipecrs#108) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Felipe Santos <[email protected]> * Update ubuntu Docker tag to jammy-20240227 (felipecrs#111) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Felipe Santos <[email protected]> * Fix shell in intermediate stage * Update dependency jenkinsci/docker-agent to v3206.vb_15dcf73f6a_9-5 * Refactor legacy s6-overlay services.d into s6-rc.d (felipecrs#114) * Set startup time per s6-overlay service (felipecrs#115) * Split image into devcontainer and jenkins-agent-dind (felipecrs#117) * Fix paths in renovate.json after rename [skip ci] * Fix image push * Fix image push (again) * Update dependency jenkinsci/docker-agent to v3206.vb_15dcf73f6a_9-6 * Update dependency jenkinsci/docker-agent to v3206.vb_15dcf73f6a_9-7 * Configure GitHub Actions cache (felipecrs#124) * Update dependency moby/moby to v25.0.5 * Update dependency docker/compose to v2.25.0 * Update dependency docker/buildx to v0.13.1 (felipecrs#118) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Felipe Santos <[email protected]> * Only pin docker-ce version (felipecrs#127) * Retain USER and HOME env vars when running with docker exec * Add tests for USER env var * Reduce sleeps * Check docker socket through mountpoint * Speed up Jenkins startup in test * Fix devcontainer not running entrypoint * Fix description label of the images * Fix build cache in CI not being used properly Refs docker/buildx#1044 * Update jenkins/jenkins Docker tag to v2.440.2 * Combine dockerfiles to improve caching (felipecrs#130) Because apparently bake does not cache linked build contexts. * Update dependency moby/moby to v26 (felipecrs#131) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Fix images description in ghcr.io (felipecrs#133) * Add test for SSHD in devcontainer (felipecrs#135) * Test scripted pipeline mounting ~/.m2 (felipecrs#136) * Ship a better default Dockerfile `SHELL` (felipecrs#137) * Update dependency moby/moby to v26.0.1 * Update ubuntu Docker tag to jammy-20240405 * Update jenkins/jenkins Docker tag to v2.440.3 * Update dependency moby/moby to v26.0.2 * Update dependency moby/moby to v26.1.0 * Update ubuntu Docker tag to jammy-20240416 * Update Ubuntu 22.04 to 24.04 (felipecrs#144) * Add Volta back as a pkgx stub (felipecrs#146) * Move Volta stub to ~/.local/bin instead of /usr/local/bin (felipecrs#148) * Add python3 and pipx (felipecrs#149) * Update dependency moby/moby to v26.1.1 * Update ubuntu Docker tag to noble-20240429 * Prefer volta binaries over pkgx ones if available (felipecrs#152) * Inherit DOMAIN from parent container for /ssh-command/get.sh (felipecrs#153) * Update dependency moby/moby to v26.1.2 * Update Jenkins Agent JDK from 17 to 21 (felipecrs#155) * Bypass dind hack when running with Sysbox (felipecrs#156) * Add wget back to devcontainer and jenkins-agent-dind Wget was part of v1, but was unintentionally removed in v2. * Update dependency jenkinsci/helm-charts to v5.1.13 * Update dependency jenkinsci/helm-charts to v5.1.15 * Update dependency jenkinsci/helm-charts to v5.1.16 * Update dependency moby/moby to v26.1.3 * Update dependency jenkinsci/helm-charts to v5.1.17 * Update dependency jenkinsci/helm-charts to v5.1.18 * Update dependency jenkinsci/helm-charts to v5.1.20 * Update dependency jenkinsci/helm-charts to v5.1.21 * Update dependency jenkinsci/helm-charts to v5.1.22 * Update dependency jenkinsci/helm-charts to v5.1.23 * Update dependency jenkinsci/helm-charts to v5.1.24 * Update dependency jenkinsci/helm-charts to v5.1.25 * Update dependency jenkinsci/helm-charts to v5.1.26 * Update ubuntu Docker tag to noble-20240530 * Update dependency moby/moby to v26.1.4 * Update dependency jenkinsci/helm-charts to v5.1.28 * Update dependency jenkinsci/helm-charts to v5.1.29 * Update dependency jenkinsci/helm-charts to v5.1.30 * Update dependency jenkinsci/helm-charts to v5.1.31 * Update dependency jenkinsci/helm-charts to v5.2.0 * Update dependency jenkinsci/helm-charts to v5.2.1 * Update dependency jenkinsci/helm-charts to v5.2.2 * Update docker/bake-action action to v5 (felipecrs#179) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update ubuntu Docker tag to noble-20240605 * Update dependency jenkinsci/helm-charts to v5.3.0 * Update dependency jenkinsci/helm-charts to v5.3.1 * Update dependency moby/moby to v27 (felipecrs#183) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency moby/moby to v27.0.2 * Use my pkgx fork while main repo is inactive (felipecrs#185) * Update dependency jenkinsci/helm-charts to v5.3.2 * Update dependency jenkinsci/helm-charts to v5.3.3 * Create FUNDING.yml * Update dependency felipecrs/pkgx to 1.2.0-felipecrs.1 (felipecrs#189) * Update dependency moby/moby to v27.0.3 * Improve Renovate depNames * Try to fix Renovate for felipecrs/pkgx * Remove unnecessary Renovate config for felipecrs/pkgx * Update dependency felipecrs/pkgx to v1.2.0-felipecrs.2 * Update dependency jenkinsci/helm-charts to v5.3.6 * Update dependency jenkinsci/helm-charts to v5.4.1 * Update dependency jenkinsci/helm-charts to v5.4.2 * Update dependency jenkinsci/helm-charts to v5.4.3 * Update dependency docker to v27.1.0 * Update dependency docker to v27.1.1 * update ci --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Felipe Santos <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Downgrade docker compose from 2.19.1 to 2.18.1 Because of docker/compose#10751 * Revert "Downgrade docker compose from 2.19.1 to 2.18.1" Because docker compose 2.20.2 solves the issue. This reverts commit d0e25e5. * Downgrade JDK from 11.0.20 to to 11.0.19 (felipecrs#76) * Align remoting version with jenkins/docker-agent So we don't try to use non-tested versions of the remoting library. Also adds some dependencies from jenkins/docker-agent that were missing in this image. * Bump dind hack to latest version * Clean not needed data like man pages * Switch skopeo installation to skopeo-bin * Upgrade fixuid from 0.5.1 to 0.6.0 * Add retry (felipecrs#80) * Fix some hadolint issues * Bump actions/checkout from 3 to 4 (felipecrs#81) Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump docker/metadata-action from 4 to 5 (felipecrs#85) Bumps [docker/metadata-action](https://github.com/docker/metadata-action) from 4 to 5. - [Release notes](https://github.com/docker/metadata-action/releases) - [Upgrade guide](https://github.com/docker/metadata-action/blob/master/UPGRADE.md) - [Commits](docker/metadata-action@v4...v5) --- updated-dependencies: - dependency-name: docker/metadata-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump docker/build-push-action from 4 to 5 (felipecrs#84) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 4 to 5. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v4...v5) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump docker/login-action from 2 to 3 (felipecrs#83) Bumps [docker/login-action](https://github.com/docker/login-action) from 2 to 3. - [Release notes](https://github.com/docker/login-action/releases) - [Commits](docker/login-action@v2...v3) --- updated-dependencies: - dependency-name: docker/login-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump docker/setup-buildx-action from 2 to 3 (felipecrs#82) Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 2 to 3. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@v2...v3) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Honor default shell in /ssh-command/get.sh * Upgrade s6-overlay from v2 to v3 (felipecrs#78) * Revert "Downgrade JDK from 11.0.20 to to 11.0.19 (felipecrs#76)" (felipecrs#86) This reverts commit 0c9a5a9. * Revert "Upgrade s6-overlay from v2 to v3 (felipecrs#78)" This reverts commit b074844, due to just-containers/s6-overlay#558. * Upgrade s6-overlay from v2 to v3 (felipecrs#78)"" This reverts commit 70ec592. Refs felipecrs#78 Refs just-containers/s6-overlay#558 (comment) * Downgrade and pin Node.js to v18 (felipecrs#90) * Bump peter-evans/dockerhub-description from 3 to 4 (felipecrs#91) Bumps [peter-evans/dockerhub-description](https://github.com/peter-evans/dockerhub-description) from 3 to 4. - [Release notes](https://github.com/peter-evans/dockerhub-description/releases) - [Commits](peter-evans/dockerhub-description@v3...v4) --- updated-dependencies: - dependency-name: peter-evans/dockerhub-description dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update Ubuntu 20.04 to 22.04 * Fix minor README issues (felipecrs#93) * Extract image preparation into a separate script and improve it (felipecrs#94) Among other things, the new script no longer needs add-apt-repository, changes the kubernetes debian repository to the new one. As part of this improvement, we also change the base image from buildpack to ubuntu, while still keeping the build-essential package installed. This allows to trim the image size a little bit. * Stop publishing to Docker Hub (felipecrs#95) I prefer to concentrate on publishing to GitHub Container Registry, so that I don't need to maintain two accounts and also because this way all download counts are in one place. As part of this change, I also removed the Docker image from Docker Hub, so that when users try to download it again, it will fail and therefore notice that the image is no longer available there. Otherwise, they would keep using the old image without noticing that it's no longer updated. * Remove btrfs-progs and add pigz for faster docker pulls (felipecrs#96) * Remove non-generic packages from image but add pkgx (felipecrs#97) * Set docker daemon log-level to warn by default (felipecrs#98) And remove deprecated fix-attrs. * Use same JDK as jenkins/inbound-agent (upgrade to 17) (felipecrs#89) * Add automatic tests (felipecrs#59) * Add support for `arm64` architecture (felipecrs#75) * Add Oh My Bash and nano to make debugging the container easier (felipecrs#99) * Add mention to pkgx and sshd into README * Allow to run with docker on docker mode (felipecrs#100) * Setup dond-shim when running in docker on docker mode (felipecrs#101) * Configure Renovate (felipecrs#102) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Felipe Santos <[email protected]> * Format json files * Enable Renovate automerge and dependency dashboard * Remove nightly docker tags and other dev improvements * Fix build and Renovate regex * Reorganize README * Allow to run as a devcontainer (felipecrs#104) * Configure Renovate to update Docker (felipecrs#106) * Update dependency felipecrs/fixdockergid to v0.7.1 * Update dependency docker/buildx to v0.13.0 * Update dependency moby/moby to v25.0.4 (felipecrs#110) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency docker/compose to v2.24.7 (felipecrs#108) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Felipe Santos <[email protected]> * Update ubuntu Docker tag to jammy-20240227 (felipecrs#111) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Felipe Santos <[email protected]> * Fix shell in intermediate stage * Update dependency jenkinsci/docker-agent to v3206.vb_15dcf73f6a_9-5 * Refactor legacy s6-overlay services.d into s6-rc.d (felipecrs#114) * Set startup time per s6-overlay service (felipecrs#115) * Split image into devcontainer and jenkins-agent-dind (felipecrs#117) * Fix paths in renovate.json after rename [skip ci] * Fix image push * Fix image push (again) * Update dependency jenkinsci/docker-agent to v3206.vb_15dcf73f6a_9-6 * Update dependency jenkinsci/docker-agent to v3206.vb_15dcf73f6a_9-7 * Configure GitHub Actions cache (felipecrs#124) * Update dependency moby/moby to v25.0.5 * Update dependency docker/compose to v2.25.0 * Update dependency docker/buildx to v0.13.1 (felipecrs#118) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Felipe Santos <[email protected]> * Only pin docker-ce version (felipecrs#127) * Retain USER and HOME env vars when running with docker exec * Add tests for USER env var * Reduce sleeps * Check docker socket through mountpoint * Speed up Jenkins startup in test * Fix devcontainer not running entrypoint * Fix description label of the images * Fix build cache in CI not being used properly Refs docker/buildx#1044 * Update jenkins/jenkins Docker tag to v2.440.2 * Combine dockerfiles to improve caching (felipecrs#130) Because apparently bake does not cache linked build contexts. * Update dependency moby/moby to v26 (felipecrs#131) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Fix images description in ghcr.io (felipecrs#133) * Add test for SSHD in devcontainer (felipecrs#135) * Test scripted pipeline mounting ~/.m2 (felipecrs#136) * Ship a better default Dockerfile `SHELL` (felipecrs#137) * Update dependency moby/moby to v26.0.1 * Update ubuntu Docker tag to jammy-20240405 * Update jenkins/jenkins Docker tag to v2.440.3 * Update dependency moby/moby to v26.0.2 * Update dependency moby/moby to v26.1.0 * Update ubuntu Docker tag to jammy-20240416 * Update Ubuntu 22.04 to 24.04 (felipecrs#144) * Add Volta back as a pkgx stub (felipecrs#146) * Move Volta stub to ~/.local/bin instead of /usr/local/bin (felipecrs#148) * Add python3 and pipx (felipecrs#149) * Update dependency moby/moby to v26.1.1 * Update ubuntu Docker tag to noble-20240429 * Prefer volta binaries over pkgx ones if available (felipecrs#152) * Inherit DOMAIN from parent container for /ssh-command/get.sh (felipecrs#153) * Update dependency moby/moby to v26.1.2 * Update Jenkins Agent JDK from 17 to 21 (felipecrs#155) * Bypass dind hack when running with Sysbox (felipecrs#156) * Add wget back to devcontainer and jenkins-agent-dind Wget was part of v1, but was unintentionally removed in v2. * Update dependency jenkinsci/helm-charts to v5.1.13 * Update dependency jenkinsci/helm-charts to v5.1.15 * Update dependency jenkinsci/helm-charts to v5.1.16 * Update dependency moby/moby to v26.1.3 * Update dependency jenkinsci/helm-charts to v5.1.17 * Update dependency jenkinsci/helm-charts to v5.1.18 * Update dependency jenkinsci/helm-charts to v5.1.20 * Update dependency jenkinsci/helm-charts to v5.1.21 * Update dependency jenkinsci/helm-charts to v5.1.22 * Update dependency jenkinsci/helm-charts to v5.1.23 * Update dependency jenkinsci/helm-charts to v5.1.24 * Update dependency jenkinsci/helm-charts to v5.1.25 * Update dependency jenkinsci/helm-charts to v5.1.26 * Update ubuntu Docker tag to noble-20240530 * Update dependency moby/moby to v26.1.4 * Update dependency jenkinsci/helm-charts to v5.1.28 * Update dependency jenkinsci/helm-charts to v5.1.29 * Update dependency jenkinsci/helm-charts to v5.1.30 * Update dependency jenkinsci/helm-charts to v5.1.31 * Update dependency jenkinsci/helm-charts to v5.2.0 * Update dependency jenkinsci/helm-charts to v5.2.1 * Update dependency jenkinsci/helm-charts to v5.2.2 * Update docker/bake-action action to v5 (felipecrs#179) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update ubuntu Docker tag to noble-20240605 * Update dependency jenkinsci/helm-charts to v5.3.0 * Update dependency jenkinsci/helm-charts to v5.3.1 * Update dependency moby/moby to v27 (felipecrs#183) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency moby/moby to v27.0.2 * Use my pkgx fork while main repo is inactive (felipecrs#185) * Update dependency jenkinsci/helm-charts to v5.3.2 * Update dependency jenkinsci/helm-charts to v5.3.3 * Create FUNDING.yml * Update dependency felipecrs/pkgx to 1.2.0-felipecrs.1 (felipecrs#189) * Update dependency moby/moby to v27.0.3 * Improve Renovate depNames * Try to fix Renovate for felipecrs/pkgx * Remove unnecessary Renovate config for felipecrs/pkgx * Update dependency felipecrs/pkgx to v1.2.0-felipecrs.2 * Update dependency jenkinsci/helm-charts to v5.3.6 * Update dependency jenkinsci/helm-charts to v5.4.1 * Update dependency jenkinsci/helm-charts to v5.4.2 * Update dependency jenkinsci/helm-charts to v5.4.3 * Update dependency docker to v27.1.0 * Update dependency docker to v27.1.1 * update ci * Update README.md --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Felipe Santos <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Description
v2.19.0 introduced a change that broke a docker compose run command that was working previously (v2.18.1)
The change, I believe, would have come from this PR: #10602
docker compose -p unique_name run --rm --no-deps test black --line-length 150 --check app/ tests/
Error:
service postgres is required by test but is disabled. Can be enabled by profiles []
I believe this is roughly all that would be required to reproduce, but I haven't directly tested this as docker mac hasn't updated docker compose yet:
Steps To Reproduce
No response
Compose Version
Docker Environment
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: