This repository has been archived by the owner on Feb 14, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
force-pushed
the
update_golang
branch
2 times, most recently
from
January 28, 2022 14:44
1e00d3d
to
e5f2475
Compare
Probably needs a more current version of Docker Engine to run the newer alpine / debian images (otherwise seccomp may be blocking some syscalls);
|
thaJeztah
force-pushed
the
update_golang
branch
2 times, most recently
from
January 28, 2022 14:56
a93d3c0
to
4be84cf
Compare
Older versions may have issues when running recent Alpine images, due to seccomp profiles not being up to date with latest kernels. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
update_golang
branch
2 times, most recently
from
January 28, 2022 15:35
78ed796
to
af69d3e
Compare
Hoping to fix: Output from proc 3: flag provided but not defined: -ginkgo.timeout Usage of /e2e.test: -alsologtostderr log to standard error as well as files -ginkgo.dryRun If set, ginkgo will walk the test hierarchy without actually running anything. Best paired with -v. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
update_golang
branch
from
January 28, 2022 15:50
af69d3e
to
6c50f0c
Compare
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
=======================================
Coverage 65.02% 65.02%
=======================================
Files 90 90
Lines 10958 10958
=======================================
Hits 7125 7125
Misses 3537 3537
Partials 296 296 Continue to review full report at Codecov.
|
rumpl
approved these changes
Jan 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #181 (comment)