re-introduced support for port numbers in docker registry URL #5195
+21
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carston Schilds <[email protected]>
CarstonSchilds
changed the title
thaJeztah
added
kind/bugfix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5195 +/- ##
==========================================
+ Coverage 60.96% 61.43% +0.46%
==========================================
Files 295 298 +3
Lines 20789 20799 +10
==========================================
+ Hits 12674 12777 +103
+ Misses 7198 7109 -89
+ Partials 917 913 -4 |
|
🤦 Thanks! I missed that #3599 was merged, and looking at my last push there, I suspect I found some local changes that may have been WIP 😞 |
thaJeztah
requested changes
Jun 26, 2024
| if u.Port() == "" { | ||
| return u.Hostname() | ||
| } | ||
| return u.Hostname() + ":" + u.Port() |
There was a problem hiding this comment.
If we can expect IPv6 addresses, we should probably use netJoinHostPort() here;
return net.JoinHostPort(u.Hostname(), u.Port())
Comment on lines
+170
to
+171
| // should support non-standard port in registry url | ||
| { |
There was a problem hiding this comment.
We can probably add some test-cases here for IP-addresses
|
Actually, ignore my comments for now; I guess we didn't do this in the old code, so we can make those fixes in a follow-up; I opened a follow-up PR; #5196 |
thaJeztah
approved these changes
Jun 26, 2024
|
@vvoland @laurazard PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How to verify it
docker buildx bake test- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)