docs/deprecated: update status for graphdriver-plugins #5185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvoland
reviewed
Jun 21, 2024
docs/deprecated.md
Outdated
| @@ -61,7 +61,7 @@ The table below provides an overview of the current status of deprecated feature | |||
| | Removed | [logentries logging driver](#logentries-logging-driver) | v24.0 | v25.0 | | |||
| | Removed | [OOM-score adjust for the daemon](#oom-score-adjust-for-the-daemon) | v24.0 | v25.0 | | |||
| | Removed | [Buildkit build information](#buildkit-build-information) | v23.0 | v24.0 | | |||
| | Deprecated | [Legacy builder for Linux images](#legacy-builder-for-linux-images) | v23.0 | - | | |||
| | Deprecated | [Legacy builder for Linux images](#legacy-builder-for-linux-images) [deprecated.md](deprecated.md) | v23.0 | - | | |||
There was a problem hiding this comment.
Ugh! Suspect my IDE tried to be helpful somewhere? Fixing!
There was a problem hiding this comment.
Hmm.. or may be I did a CMD+V in the wrong spot; could've been me for sure!
krissetto
reviewed
Jun 21, 2024
docs/deprecated.md
Outdated
| @@ -160,6 +161,14 @@ storage drivers for storing images and containers. This feature was not | |||
| maintained since its inception, and will no longer be supported in upcoming | |||
| releases. | |||
|
|
|||
| Support for graphdriver plugins is disabled by default in v27.0, but an | |||
| `DOCKERD_DEPRECATED_GRAPHDRIVER_PLUGINS` environment variable is provided | |||
| to re-enable the feature. This environment-variable must be set in the daemon's | |||
There was a problem hiding this comment.
suggestion: "..must be set to a non-empty value in the daemon's environment."
There was a problem hiding this comment.
nit: also, let's standardize how we write "environment variable" (with or without the - between the words?)
docs/deprecated.md
Outdated
| to re-enable the feature. This environment-variable must be set in the daemon's | ||
| environment, and set to a non-empty value. | ||
|
|
||
| This environment variable will be removed in v28.0, and support for graphdriver |
There was a problem hiding this comment.
suggestion: "This environment variable, along with support for graphdriver plugins, will be removed in v28.0"
Add a mention of the feature being disabled by default, and the DOCKERD_DEPRECATED_GRAPHDRIVER_PLUGINS env-var. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
deprecate_graphdriver_plugins2
branch
from
9e84a67
to
c8c13bd
Compare
|
@krissetto @vvoland I tried to rephrase it a bit; let me know if it looks better 🙈 |
vvoland
approved these changes
Jun 21, 2024
vvoland
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a mention of the feature being disabled by default, and the DOCKERD_DEPRECATED_GRAPHDRIVER_PLUGINS env-var.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)