Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(plugins): fix typos and formatting #4767

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Jan 10, 2024

- What I did

Fix typos and formatting cruft for the plugin docs

Diff is proper messy but it's all indentation and double spaces and typos, things like that

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@dvdksn dvdksn requested a review from thaJeztah as a code owner January 10, 2024 09:39
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

Merging #4767 (3df1495) into master (cfe18f5) will increase coverage by 0.00%.
Report is 54 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4767   +/-   ##
=======================================
  Coverage   59.62%   59.63%           
=======================================
  Files         287      287           
  Lines       24777    24777           
=======================================
+ Hits        14774    14775    +1     
+ Misses       9117     9114    -3     
- Partials      886      888    +2     

@dvdksn dvdksn force-pushed the refresh-plugin-docs branch from 625f7b5 to 2c9b782 Compare January 10, 2024 10:07
docs/extend/plugin_api.md Show resolved Hide resolved
docs/extend/plugin_api.md Outdated Show resolved Hide resolved
docs/extend/plugins_logging.md Outdated Show resolved Hide resolved
@dvdksn dvdksn force-pushed the refresh-plugin-docs branch from 2c9b782 to a8e5e26 Compare January 11, 2024 08:34
@dvdksn dvdksn requested a review from thaJeztah January 11, 2024 08:34
@dvdksn dvdksn force-pushed the refresh-plugin-docs branch from a8e5e26 to 3df1495 Compare January 16, 2024 19:37
@dvdksn
Copy link
Contributor Author

dvdksn commented Jan 16, 2024

changed the bullet lists to just Request: / Response:, think it's good now @thaJeztah

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit d161a2a into docker:master Jan 17, 2024
77 checks passed
@dvdksn dvdksn deleted the refresh-plugin-docs branch January 17, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants