Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: migrate to github.com/go-viper/mapstructure/v2 v2.0.0 #4744

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Dec 27, 2023

github.com/mitchellh/mapstructure will no longer be maintained by the author,
and github.com/go-viper/mapstructure is nominated as the endorsed fork.

Breaking changes

Error is removed in favor of errors.Join (backported from Go 1.20 to preserve
compatibility with earlier versions)

What's Changed

  • feat!: update module path
  • build: update dev env
  • feature: add StringToBasicTypeHookFunc and support complex
  • Add an example showing how to use a DecodeHookFunc to parse a custom field.
  • Remove exposed error type
  • Replace internal joined error with errors.Join

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.37%. Comparing base (6b5ebfb) to head (bc2e274).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4744   +/-   ##
=======================================
  Coverage   61.37%   61.37%           
=======================================
  Files         298      298           
  Lines       20717    20717           
=======================================
  Hits        12715    12715           
  Misses       7102     7102           
  Partials      900      900           

@thaJeztah thaJeztah force-pushed the migrate_mapstructure branch from 6e00963 to 39c9ebc Compare December 27, 2023 16:49
@thaJeztah thaJeztah force-pushed the migrate_mapstructure branch from 39c9ebc to dafb92b Compare June 3, 2024 08:24
@thaJeztah thaJeztah added this to the 27.0.0 milestone Jun 3, 2024
@thaJeztah thaJeztah changed the title vendor: migrate to github.com/go-viper/mapstructure/v2 v2.0.0-alpha.1 vendor: migrate to github.com/go-viper/mapstructure/v2 v2.0.0 Jun 3, 2024
@thaJeztah thaJeztah marked this pull request as ready for review June 3, 2024 10:43
@thaJeztah thaJeztah self-assigned this Jun 5, 2024
github.com/mitchellh/mapstructure will no longer be maintained by the author,
and github.com/go-viper/mapstructure is nominated as the endorsed fork.

- v1.x changes since last release from mitchellh: go-viper/mapstructure@v1.5.0...v1.6.0
- v2.0 changes: go-viper/mapstructure@v1.6.0...v2.0.0

Breaking changes

Error is removed in favor of errors.Join (backported from Go 1.20 to preserve
compatibility with earlier versions)

What's Changed

- feat!: update module path
- build: update dev env
- feature: add StringToBasicTypeHookFunc and support complex
- Add an example showing how to use a DecodeHookFunc to parse a custom field.
- Remove exposed error type
- Replace internal joined error with errors.Join

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah force-pushed the migrate_mapstructure branch from dafb92b to bc2e274 Compare June 5, 2024 22:06
@@ -171,9 +173,8 @@ github.com/matttproud/golang_protobuf_extensions v1.0.4/go.mod h1:BSXmuO+STAnVfr
github.com/miekg/pkcs11 v1.0.3/go.mod h1:XsNlhZGX73bx86s2hdc/FuaLm2CPZJemRLMA+WTFxgs=
github.com/miekg/pkcs11 v1.1.1 h1:Ugu9pdy6vAYku5DEpVWVFPYnzV+bxB+iRdbuFSu7TvU=
github.com/miekg/pkcs11 v1.1.1/go.mod h1:XsNlhZGX73bx86s2hdc/FuaLm2CPZJemRLMA+WTFxgs=
github.com/mitchellh/mapstructure v1.0.0 h1:vVpGvMXJPqSDh2VYHF7gsfQj8Ncx+Xw5Y1KHeTRY+7I=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 why is this 1.0.0 version still here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's Notary that still has it somewhere listed;

go mod graph | grep ' github.com/mitchellh/mapstructure'
github.com/theupdateframework/[email protected] github.com/mitchellh/[email protected]

Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laurazard laurazard merged commit 465208e into docker:master Jun 6, 2024
88 checks passed
@thaJeztah thaJeztah deleted the migrate_mapstructure branch June 6, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants