Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker ps status descriptions #4614

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

sam-thibault
Copy link
Contributor

@sam-thibault sam-thibault commented Oct 20, 2023

- What I did

Added a table to docker ps documentation to describe the meaning of each status.

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@codecov-commenter
Copy link

Codecov Report

Merging #4614 (42ff281) into master (8743ffd) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4614   +/-   ##
=======================================
  Coverage   59.72%   59.72%           
=======================================
  Files         288      288           
  Lines       24846    24846           
=======================================
  Hits        14839    14839           
  Misses       9120     9120           
  Partials      887      887           

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM, but left a comment about formatting.

docs/reference/commandline/ps.md Outdated Show resolved Hide resolved
docs/reference/commandline/ps.md Outdated Show resolved Hide resolved
Copy link
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @sam-thibault

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 4d6cf13 into docker:master Oct 20, 2023
74 checks passed
@sam-thibault sam-thibault deleted the cli-issue-502 branch October 20, 2023 10:53
@dvdksn
Copy link
Contributor

dvdksn commented Oct 20, 2023

Should we backport or leave it for v25?
Nvm just saw the milestone :^)

@thaJeztah
Copy link
Member

@dvdksn yes, we should backport this one to the v24 branch; didn't come round to that yet, but feel free to beat me to it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants