-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker ps status descriptions #4614
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4614 +/- ##
=======================================
Coverage 59.72% 59.72%
=======================================
Files 288 288
Lines 24846 24846
=======================================
Hits 14839 14839
Misses 9120 9120
Partials 887 887 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall LGTM, but left a comment about formatting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @sam-thibault
Signed-off-by: Sam Thibault <[email protected]>
42ff281
to
8bf121c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@dvdksn yes, we should backport this one to the v24 branch; didn't come round to that yet, but feel free to beat me to it :) |
- What I did
Added a table to docker ps documentation to describe the meaning of each status.
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)