Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update status of deprecated features for 22.04 (docs, and some code) #3542

Merged
merged 7 commits into from
Apr 8, 2022

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Apr 7, 2022

Mostly docs, but some code-changes

docs: reformat table for compatibility

My IDE's linter kept complaining:

For compatibility reasons all table rows should have borders (pipe
symbols) at the start and at the end.

update deprecation status of --kernel-memory(-tcp)

Update the flag annotations and description

docs: update deprecation status of aufs, overlay, and devicemapper

docs: update deprecation status of legacy overlay networks

docs: update deprecation status for overlay(2) on backingfs without d_type

docs: update deprecation status of "experimental" cli

Change future tense to current tense.

cli/command/system: remove printStorageDriverWarnings()

These warnings were for features that are no longer supported (overlay
on a backingFS without d_type support), or related to the deprecated
devicemapper storage driver.

Removing this function for that reason.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

My IDE's linter kept complaining:

> For compatibility reasons all table rows should have borders (pipe
> symbols) at the start and at the end.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Change future tense to current tense.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
These warnings were for features that are no longer supported (overlay
on a backingFS without d_type support), or related to the deprecated
devicemapper storage driver.

Removing this function for that reason.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #3542 (63fb35b) into master (429d716) will increase coverage by 0.05%.
The diff coverage is 0.00%.

❗ Current head 63fb35b differs from pull request most recent head 51aa683. Consider uploading reports for the commit 51aa683 to get more accurate results

@@            Coverage Diff             @@
##           master    #3542      +/-   ##
==========================================
+ Coverage   59.05%   59.10%   +0.05%     
==========================================
  Files         282      282              
  Lines       23796    23770      -26     
==========================================
- Hits        14053    14050       -3     
+ Misses       8883     8864      -19     
+ Partials      860      856       -4     

Comment on lines +306 to +307
> and not available on installations running with cgroups v2. This option is
> only supported by the API, and not exposed on the `docker` command-line.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL, so I went looking for the --kernel-memory-tcp flag, but it looks like we never exposed this option on the CLI (perhaps through compose or swarm though?)

@thaJeztah
Copy link
Member Author

@ndeloof @cpuguy83 @rumpl ptal

@thaJeztah
Copy link
Member Author

Thx!

@thaJeztah thaJeztah merged commit 5df36e5 into docker:master Apr 8, 2022
@thaJeztah thaJeztah deleted the update_deprecated branch April 8, 2022 13:47
matt9ucci added a commit to matt9ucci/DockerCompletion that referenced this pull request Feb 9, 2023
matt9ucci added a commit to matt9ucci/DockerCompletion that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants