bump imdario/mergo v0.3.12 #3304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
full diff: imdario/[email protected] includes: - darccio/mergo@c085d66 use src map if dst is nil and can't be set - fixes darccio/mergo#90 panic: reflect: reflect.Value.Set using unaddressable value merging nested structures Signed-off-by: Jonathan Warriss-Simmons <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #3304 +/- ##
=======================================
Coverage 57.99% 57.99%
=======================================
Files 302 302
Lines 21764 21764
=======================================
Hits 12621 12621
Misses 8219 8219
Partials 924 924 |
thaJeztah
approved these changes
Sep 23, 2021
|
|
||
| go 1.13 | ||
|
|
||
| require gopkg.in/yaml.v2 v2.3.0 |
There was a problem hiding this comment.
Was looking if we needed to update this one as well (currently we're using v2.2.8), but looks like the changes are not very relevant; go-yaml/yaml@v2.2.8...v2.3.0
|
@silvin-lubecki PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Bumps mergo from v0.3.8 to v0.3.12
full diff: imdario/[email protected]
includes:
Signed-off-by: Jonathan Warriss-Simmons [email protected]
- How I did it
Updated vendor.conf
- How to verify it
Existing unit tests should cover everything - as it's just a bump in version. However, it's my first time contributing, so I'd appreciate a check of that!
- Description for the changelog
Bumps mergo dependency from v0.3.8 to v0.3.12
- A picture of a cute animal (not mandatory but encouraged)