[draft][19.03 backport] Remove "docker engine" subcommands #2829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These subcommands were created to allow upgrading a Docker Community engine to Docker Enterprise, but never really took off. This patch removes the `docker engine` subcommands, as they added quite some complexity / additional code. Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 43b2f52) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 7e54513) Signed-off-by: Sebastiaan van Stijn <[email protected]>
|
hm. CircleCI for some reason isn't triggered on this PR (Jenkins is though) |
hc0503
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2207
alternative to / closes #2828
Opening this for discussion; These subcommands were created to allow upgrading a Docker Community engine to Docker Enterprise, but with the move of the enterprise products to Mirantis, these commands were no longer working; the images used to distribute the "enterprise" engine are no longer updated, and the latest versions available on docker hub are outdated (and may have unpatched vulnerabilities, so should not be recommended to use).
Reference documentation for these subcommands were already removed from docs.docker.com, and removing these commands (even as part of a patch release) may be the best option.
addresses #2213