login: print a big warning when using --password #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 29, 2017
Merged
Codecov Report
@@ Coverage Diff @@
## master #270 +/- ##
==========================================
- Coverage 48.44% 46.85% -1.59%
==========================================
Files 173 172 -1
Lines 11748 11692 -56
==========================================
- Hits 5691 5478 -213
- Misses 5696 5902 +206
+ Partials 361 312 -49 |
thaJeztah
requested changes
Jul 1, 2017
cli/command/registry/login.go
Outdated
| @@ -47,6 +47,10 @@ func runLogin(dockerCli command.Cli, opts loginOptions) error { | |||
| ctx := context.Background() | |||
| clnt := dockerCli.Client() | |||
|
|
|||
| if opts.password != "" { | |||
| fmt.Fprintf(dockerCli.Err(), "Using --password via the CLI is insecure.\n") | |||
There was a problem hiding this comment.
Can you change this to fmt.Fprintln()?
Perhaps prefix with WARNING! ;
fmt.Fprintln(dockerCli.Err(), "WARNING! Using --password via the CLI is insecure.")
Task command lines are world readable via /proc/pid/cmdline, so this isn't safe. Signed-off-by: Tycho Andersen <[email protected]>
tych0
force-pushed
the
warn-only-about-password-on-cli
branch
from
952d7da
to
c269ad2
Compare
|
LGTM! |
|
LGTM ping @thaJeztah |
thaJeztah
approved these changes
Jul 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task command lines are world readable via /proc/pid/cmdline, so this isn't
safe.