progress: Show progress of replicated tasks before they are assigned #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was only showing tasks that belong to nodes that are currently up, so that tasks on down nodes don't appear to be stuck. But this unintentionally excludes tasks that haven't been assigned yet, so if a task is stuck before assignment, for example because no nodes meet its constraints, a progress bar won't even be shown. The check should only apply to tasks that have a node assignment. Signed-off-by: Aaron Lehmann <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
==========================================
- Coverage 47.2% 45.67% -1.53%
==========================================
Files 171 171
Lines 11556 11513 -43
==========================================
- Hits 5455 5259 -196
- Misses 5790 5947 +157
+ Partials 311 307 -4 |
|
Without this patch; $ docker service create --name donotdeploy --constraint "node.labels.somelabel==foobar" --detach=false nginx:alpine
0wx8h7rp50tqg0xnykwbxy4n6
overall progress: 0 out of 1 tasks
1/1:With this patch applied; ./docker service create --name donotdeploy --constraint "node.labels.somelabel==foobar" --detach=false nginx:alpine
ve5pnzf0swqtapeb0uqnla2cz
overall progress: 0 out of 1 tasks
1/1: pending [================> ] |
|
After applying the label; $ docker service create --name donotdeploy --constraint "node.labels.somelabel==foobar" --detach=false nginx:alpine
ve5pnzf0swqtapeb0uqnla2cz
overall progress: 1 out of 1 tasks
1/1: running [==================================================>]
verify: Waiting 1 seconds to verify that tasks are stable...guess I found another issue ( |
|
All green 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was only showing tasks that belong to nodes that are currently up,
so that tasks on down nodes don't appear to be stuck. But this
unintentionally excludes tasks that haven't been assigned yet, so if a
task is stuck before assignment, for example because no nodes meet its
constraints, a progress bar won't even be shown. The check should only
apply to tasks that have a node assignment.
Related to moby/moby#33807
cc @thaJeztah