Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump vndr v0.1.0, mjibson/esc v0.2.0, gotestsum v0.4.0 #2275

Merged
merged 4 commits into from
Jan 28, 2020

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jan 20, 2020

bump vndr v0.1.0 to support versioned import paths

With this change, go packages/modules that use versioned
import paths (github.com/foo/bar/v2), but don't use a directory
in the repository, can now be supported.

For example:

github.com/coreos/go-systemd/v22 v22.0.0

will vendor the github.com/coreos/go-systemd repository
into vendor/github.com/coreos/go-systemd/v22.

full diff: LK4D4/vndr@b177b58...v0.1.0

bump mjibson/esc v0.2.0

full diff: maddyblue/esc@v0.1.0...v0.2.0

includes:

bump gotestsum v0.3.5

full diff: gotestyourself/gotestsum@v0.3.4...v0.3.5

bump gotestsum v0.4.0

full diff: gotestyourself/gotestsum@v0.3.5...v0.4.0

includes:

@silvin-lubecki
Copy link
Contributor

@thaJeztah why not bumping gotestsum to v0.4 ?

RUN go get -d github.com/mjibson/esc && \
cd /go/src/github.com/mjibson/esc && \
git checkout -q "$ESC_SHA" && \
go build -v -o /usr/bin/esc . && \
rm -rf /go/src/* /go/pkg/* /go/bin/*

ARG GOTESTSUM_VERSION=0.3.4
ARG GOTESTSUM_VERSION=0.3.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we also bump it in Dockerfile.e2e?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahum, overlooked that one; I'll update that one, and push an additional commit to bump it to v0.4.0

With this change, go packages/modules that use versioned
import paths (github.com/foo/bar/v2), but don't use a directory
in the repository, can now be supported.

For example:

```
github.com/coreos/go-systemd/v22 v22.0.0
```

will vendor the github.com/coreos/go-systemd repository
into `vendor/github.com/coreos/go-systemd/v22`.

full diff: LK4D4/vndr@b177b58...v0.1.0

- LK4D4/vndr#79 Add more clear messages around clone failures
- LK4D4/vndr#80 add riscv64 support
- LK4D4/vndr#83 migrate bitbucket to api 2.0
    - fixes LK4D4/vndr#82 https://api.bitbucket.org/1.0/repositories/ww/goautoneg: 410 Gone
- LK4D4/vndr#86 Replace sort.Sort with sort.Strings
- LK4D4/vndr#87 support `github.com/coreos/go-systemd/v22`

Signed-off-by: Sebastiaan van Stijn <[email protected]>
full diff: maddyblue/esc@v0.1.0...v0.2.0

includes:

- maddyblue/esc#51 Readdir Implementation - and covering with tests
- maddyblue/esc#53 update go versions and golint import location
- maddyblue/esc#58 Avoid unnecessary conversion and so pass with unconvert linter

Signed-off-by: Sebastiaan van Stijn <[email protected]>
full diff: gotestyourself/gotestsum@v0.3.4...v0.3.5

- gotestyourself/gotestsum#52 Add a --version flag that goreleaser will populate for us
- gotestyourself/gotestsum#57 Identify and, filter or display coverage output

Signed-off-by: Sebastiaan van Stijn <[email protected]>
full diff: gotestyourself/gotestsum@v0.3.5...v0.4.0

includes:

- gotestyourself/gotestsum#59 Report if a package was cached in short formats
- gotestyourself/gotestsum#63 always colorize output unless specifically requested not to
- gotestyourself/gotestsum#61 Improve short-verbose output for tests in CWD
- gotestyourself/gotestsum#70 gotestyourself/gotestsum#70
- gotestyourself/gotestsum#73 Add short-with-failures format

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah changed the title Bump vndr v0.1.0, mjibson/esc v0.2.0, gotestsum v0.3.5 Bump vndr v0.1.0, mjibson/esc v0.2.0, gotestsum v0.4.0 Jan 27, 2020
@thaJeztah
Copy link
Member Author

@silvin-lubecki updated; PTAL

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki silvin-lubecki merged commit 7742164 into docker:master Jan 28, 2020
@thaJeztah thaJeztah deleted the bump_utils branch January 28, 2020 15:40
@thaJeztah thaJeztah added this to the next milestone Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

https://api.bitbucket.org/1.0/repositories/ww/goautoneg: 410 Gone
3 participants