Remove remaining uses of pkg/homedir #2143
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created to address build failures when updating buildkit to vendor a more recent version of docker which is not currently usable by this package.
- What I did
Remove uses of
"github.com/docker/docker/pkg/homedir".Get
.- How I did it
Replaced it with
os.UserHomeDir
which was added in Go 1.12 and is already in use in other places in this package.- How to verify it
Run the tests and ensure everything builds. Comments explain why errors were unhandled to prevent confusion later.
Previous behavior can be found here.
- Description for the changelog
n/a