Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.09 backport] vendor: Bump gopkg.in/yaml.v2 #2118

Merged

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Oct 1, 2019

backport of #2117

To mitigate against malicious YAML (kubernetes/kubernetes#83253), we had implemented our own patch to the yams.v2 library. Now that there's an upstream fix, this PR brings us back to using the upstream library.

Description for the changelog

  • Mitigate against YAML files that has excessive aliasing

Signed-off-by: Christopher Crone <[email protected]>
(cherry picked from commit 91cf8b0)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Copy link
Member Author

ping @silvin-lubecki @chris-crone @vdemeester PTAL

@codecov-io
Copy link

Codecov Report

Merging #2118 into 18.09 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            18.09    #2118   +/-   ##
=======================================
  Coverage   54.28%   54.28%           
=======================================
  Files         291      291           
  Lines       19459    19459           
=======================================
  Hits        10563    10563           
  Misses       8215     8215           
  Partials      681      681

Copy link
Member

@chris-crone chris-crone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu andrewhsu merged commit 0fcc210 into docker:18.09 Oct 3, 2019
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah deleted the 18.09_backport_bump_yaml.v2_2.2.3 branch October 4, 2019 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants