TestSigProxyWithTTY: fix #2016
Merged
TestSigProxyWithTTY: fix #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolyshkin
force-pushed
the
TestSigProxyWithTTY
branch
from
c452c79 to
13eb231
Compare
Codecov Report
@@ Coverage Diff @@
## master #2016 +/- ##
=======================================
Coverage 56.79% 56.79%
=======================================
Files 311 311
Lines 21836 21836
=======================================
Hits 12402 12402
Misses 8519 8519
Partials 915 915 |
kolyshkin
force-pushed
the
TestSigProxyWithTTY
branch
7 times, most recently
from
c3d7850 to
ba3d3d8
Compare
exec.CombinedOutput should not be used here because: - it redirects cmd Stdout and Stderr and we want it to be the tty - it calls cmd.Run which we already did While at it - use pty.Start() as it is cleaner - make sure we don't leave a zombie running, by calling Wait() in defer - use test.Name() for containerName Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
force-pushed
the
TestSigProxyWithTTY
branch
from
ba3d3d8 to
e085cd3
Compare
kolyshkin
force-pushed
the
TestSigProxyWithTTY
branch
from
e085cd3 to
bc4ed69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exec.CombinedOutput()should not be used here because:cmd.Run()which we already didWhile at it
pty.Start()as it is cleanerWait()in defertest.Name()forcontainerName