Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: use stable-dind image for testing #1992

Merged
merged 1 commit into from
Jul 10, 2019

Conversation

thaJeztah
Copy link
Member

The edge channel is deprecated and no longer updated

@thaJeztah thaJeztah changed the title e2e: use stable channel for dind daemon e2e: use 18.09 daemon Jul 10, 2019
@codecov-io
Copy link

Codecov Report

Merging #1992 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1992      +/-   ##
==========================================
- Coverage   56.74%   56.74%   -0.01%     
==========================================
  Files         310      310              
  Lines       21802    21801       -1     
==========================================
- Hits        12371    12370       -1     
  Misses       8517     8517              
  Partials      914      914

@thaJeztah
Copy link
Member Author

@silvin-lubecki @vdemeester PTAL; wasn't sure what we preferred here;

  • use test-dind (latest "RC"); gives the advantage of testing against latest/greatest, but this image may change at points so possibly cause inconsistent results
  • use stable-dind same "problem" as above
  • pin to a specific version (this PR); downside is that we don't catch regressions, but positive side is that we know what we're testing against

@vdemeester
Copy link
Collaborator

@silvin-lubecki @vdemeester PTAL; wasn't sure what we preferred here;

* use `test-dind` (latest "RC"); gives the advantage of testing against latest/greatest, but this image may change at points so possibly cause inconsistent results

* use `stable-dind` same "problem" as above

* pin to a specific version (this PR); downside is that we don't catch regressions, but positive side is that we know what we're testing against

I think safest bet is stable-dind. We could have another job test-dind that is not a blocker (aka we would see it needs fixing but it wouldn't be required to be green to be able to merge). @thaJeztah wdyt ?

@thaJeztah
Copy link
Member Author

I'm good with stable-dind (less maintenance) let me update

The edge channel is deprecated and no longer updated

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah changed the title e2e: use 18.09 daemon e2e: use stable-dind image for testing Jul 10, 2019
@thaJeztah
Copy link
Member Author

updated 👍

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants