image/build: print warning/error for unsupported buildkit options #1896
Conversation
Signed-off-by: bpopovschi <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1896 +/- ##
==========================================
- Coverage 56.75% 56.71% -0.05%
==========================================
Files 309 309
Lines 21680 21696 +16
==========================================
Hits 12305 12305
- Misses 8476 8492 +16
Partials 899 899 |
| @@ -71,6 +73,32 @@ func runBuildBuildKit(dockerCli command.Cli, options buildOptions) error { | |||
|
|
|||
| stdoutUsed := false | |||
|
|
|||
| if options.squash { | |||
| // return error rather than print a warning, as squash is often used for hiding secrets | |||
| return errors.New("squash is not supported by BuildKit. Consider using a multi-stage Dockerfile instead") | |||
There was a problem hiding this comment.
supported but slightly broken
moby/moby#38903
There was a problem hiding this comment.
So what should we output in error message?
There was a problem hiding this comment.
We have a PR moby/moby#39187 , probably we can just remove the error here
cc @tonistiigi
|
I'm a bit on the fence on this one, as I'd prefer the daemon to return these errors/warnings, given that a client could be used against different versions of the daemon |
|
Hey, guys, what is the status of this one? |
|
@thaJeztah any news on this one? |
|
Still not sure about this; we should annotate them with the
Let me push a quick PR with those changes; we can continue the discussion on this one (but I'd still prefer the daemon to be the source of truth here) |
|
Opened #2123 |
Based on: #1755
Added error return on squash command and warnings for all the rest, unsupported by buildkit options.
Signed-off-by: Boris Popovschi [email protected]
@AkihiroSuda