Add ip address to advanced options #1803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
thaJeztah
force-pushed
the
add_ip_address_to_advanced_options
branch
4 times, most recently
from
8b591a7
to
7c59932
Compare
Codecov Report
@@ Coverage Diff @@
## master #1803 +/- ##
==========================================
+ Coverage 56.28% 56.42% +0.13%
==========================================
Files 308 308
Lines 21299 21370 +71
==========================================
+ Hits 11988 12057 +69
+ Misses 8436 8434 -2
- Partials 875 879 +4 |
Codecov Report
@@ Coverage Diff @@
## master #1803 +/- ##
==========================================
+ Coverage 56.32% 56.34% +0.02%
==========================================
Files 308 308
Lines 21387 21397 +10
==========================================
+ Hits 12047 12057 +10
Misses 8461 8461
Partials 879 879 |
This allows setting the ip/ipv6 address as an option in the advanced `--network` syntax; ``` docker run --network name=mynetwork,ip=172.20.88.22,ip6=2001:db8::8822 ``` Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
add_ip_address_to_advanced_options
branch
from
7c59932
to
70d8e0b
Compare
|
rebased @silvin-lubecki @vdemeester this should be ready for review as well 🤗 |
thaJeztah
commented
Apr 3, 2019
| networkOptName = "name" | ||
| networkOptAlias = "alias" | ||
| networkOptIPv4Address = "ip" | ||
| networkOptIPv6Address = "ip6" |
There was a problem hiding this comment.
Let me know if this naming LGTY; I see the compose-file uses https://docs.docker.com/compose/compose-file/#ipv4_address-ipv6_address
ipv4_address: 172.16.238.10
ipv6_address: 2001:3984:3989::10
|
We need a follow-up to update the docs and examples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up to #1767
partially implements: moby/moby#31964 (RFC: add advanced "csv" syntax for "--net" / "--network")
this allows setting the ip/ipv6 address as a network-option;