-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.09 backport] fixes 1492: tty initial size error #1775
Merged
andrewhsu
merged 2 commits into
docker:18.09
from
thaJeztah:18.09_backport_ttyexecresize
Mar 28, 2019
Merged
[18.09 backport] fixes 1492: tty initial size error #1775
andrewhsu
merged 2 commits into
docker:18.09
from
thaJeztah:18.09_backport_ttyexecresize
Mar 28, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om moby/moby to docker/cli. The integration test TestExportContainerWithOutputAndImportImage in moby/moby is the same as TestExportContainerAndImportImage, except for the output file option. Adding a unit test to cover the output file option of the export command here allows the removal of the redundant integration test TestExportContainerWithOutputAndImportImage. Signed-off-by: Arash Deshmeh <[email protected]> (cherry picked from commit fc1e11d) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Lifubang <[email protected]> Signed-off-by: lifubang <[email protected]> (cherry picked from commit 3fbffc6) Signed-off-by: Sebastiaan van Stijn <[email protected]>
ping @silvin-lubecki @kolyshkin ptal |
Codecov Report
@@ Coverage Diff @@
## 18.09 #1775 +/- ##
==========================================
+ Coverage 54.07% 54.22% +0.15%
==========================================
Files 290 290
Lines 19414 19428 +14
==========================================
+ Hits 10498 10535 +37
+ Misses 8244 8214 -30
- Partials 672 679 +7 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## 18.09 #1775 +/- ##
==========================================
+ Coverage 54.07% 54.22% +0.15%
==========================================
Files 290 290
Lines 19414 19428 +14
==========================================
+ Hits 10498 10535 +37
+ Misses 8244 8214 -30
- Partials 672 679 +7 |
silvin-lubecki
approved these changes
Mar 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #1377 and #1529 for 18.09
fixes #1492
For Ubuntu 16.04.2 LTS (GNU/Linux 4.4.0-62-generic x86_64), Docker version 17.12.0-ce, build c97c6d6 / 18.03.0-ce, build 0520e24
When I run:
docker exec -it ubuntu /bin/bash
The tty's size is small than window's size.
After I fix the bug:
If not fix this bug, it's too inconvenient for me to use docker exec -it.
- What I did
I think it's a bug of dockerd, but for previous dockerd edition, I think we can fix it in cli.
- How I did it
func MonitorTtySize in file cli/command/container/tty.goI move the call resizeTty() to last and run it asynchronously.\r
when logrus.Debugf.- How to verify it
It's convenient for me to use docker exec -it.
I don't need to resize the window.
- Description for the changelog
fixes tty initial size error
- I have no more cute animal now
Before fix:
vim /etc/mime.types
After fix:
vim /etc/mime.types