[18.09 backport] Fixes for e2e testing after Alpine bump #1729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 12, 2019 10:35
... in preference to `chsh`, since in recent alpine 3.9.2 images that can fail
with:
Password: chsh: PAM: Authentication token manipulation error
Which seems to relate to the use of `!` as the password for `root` in `/etc/shadow`gq
Signed-off-by: Ian Campbell <[email protected]>
(cherry picked from commit 5de2d9e)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
... for improved readability Signed-off-by: Ian Campbell <[email protected]> (cherry picked from commit e854a9c) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Ian Campbell <[email protected]> (cherry picked from commit 0b0c578) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 18.09 #1729 +/- ##
=======================================
Coverage 54.09% 54.09%
=======================================
Files 290 290
Lines 19406 19406
=======================================
Hits 10498 10498
Misses 8236 8236
Partials 672 672 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## 18.09 #1729 +/- ##
=======================================
Coverage 54.09% 54.09%
=======================================
Files 290 290
Lines 19406 19406
=======================================
Hits 10498 10498
Misses 8236 8236
Partials 672 672 |
|
ping @vdemeester @silvin-lubecki PTAL 🤗 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #1728 for 18.09
Somewhere between Thursday and Friday last week the
docker:test-dindimage was updated from an alpine 3.9.0 base to 3.9.2. This broke the use ofchshine2e/testdata/Dockerfile.connhelper-ssh:(this seems to relate to
root's entry in/etc/shadowchanging fromroot:::0:::::\nbin:!::0:::::toroot:!::0:::::\nbin:!::0:::::).Avoid this by just using the
--shelloption touseraddinstead.Also simplify things by using
--passwordinstead ofusermod -p(even though this was not broken) and also spell out-min full as--create-homefor clarity.