-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bash completion for docker context
command family
#1619
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1619 +/- ##
=======================================
Coverage 55.16% 55.16%
=======================================
Files 301 301
Lines 20384 20384
=======================================
Hits 11244 11244
Misses 8335 8335
Partials 805 805 |
1c49fe6
to
f2cb76d
Compare
ae0e647
to
4b92f12
Compare
Signed-off-by: Harald Albers <[email protected]>
fa93b62
to
41bd8da
Compare
docker context
command familydocker context
command family
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also note the --context (or -c) global flag. It should have a similar impact as --host on other completion scripts (list of containers, images etc.)
Otherwise seems good to me :)
Signed-off-by: Harald Albers <[email protected]>
@simonferquel Done.
|
That seems good, I can't test it right now though :/ ping @vdemeester or @thaJeztah |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a shell completion expert at all, but as far as I can tell, it looks good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐯
/cc @thaJeztah
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Ref: #1501